mirror of
https://github.com/intel/llvm.git
synced 2026-01-28 00:15:21 +08:00
A lot of comments in LLDB are surrounded by an ASCII line to delimit the begging and end of the comment. Its use is not really consistent across the code base, sometimes the lines are longer, sometimes they are shorter and sometimes they are omitted. Furthermore, it looks kind of weird with the 80 column limit, where the comment actually extends past the line, but not by much. Furthermore, when /// is used for Doxygen comments, it looks particularly odd. And when // is used, it incorrectly gives the impression that it's actually a Doxygen comment. I assume these lines were added to improve distinguishing between comments and code. However, given that todays editors and IDEs do a great job at highlighting comments, I think it's worth to drop this for the sake of consistency. The alternative is fixing all the inconsistencies, which would create a lot more churn. Differential revision: https://reviews.llvm.org/D60508 llvm-svn: 358135
39 lines
1.5 KiB
C++
39 lines
1.5 KiB
C++
//===-- CFCString.h ---------------------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef CoreFoundationCPP_CFString_h_
|
|
#define CoreFoundationCPP_CFString_h_
|
|
|
|
#include <iosfwd>
|
|
|
|
#include "CFCReleaser.h"
|
|
|
|
class CFCString : public CFCReleaser<CFStringRef> {
|
|
public:
|
|
// Constructors and Destructors
|
|
CFCString(CFStringRef cf_str = NULL);
|
|
CFCString(const char *s, CFStringEncoding encoding = kCFStringEncodingUTF8);
|
|
CFCString(const CFCString &rhs);
|
|
CFCString &operator=(const CFCString &rhs);
|
|
virtual ~CFCString();
|
|
|
|
const char *GetFileSystemRepresentation(std::string &str);
|
|
CFStringRef SetFileSystemRepresentation(const char *path);
|
|
CFStringRef SetFileSystemRepresentationFromCFType(CFTypeRef cf_type);
|
|
CFStringRef SetFileSystemRepresentationAndExpandTilde(const char *path);
|
|
const char *UTF8(std::string &str);
|
|
CFIndex GetLength() const;
|
|
static const char *UTF8(CFStringRef cf_str, std::string &str);
|
|
static const char *FileSystemRepresentation(CFStringRef cf_str,
|
|
std::string &str);
|
|
static const char *ExpandTildeInPath(const char *path,
|
|
std::string &expanded_path);
|
|
};
|
|
|
|
#endif // #ifndef CoreFoundationCPP_CFString_h_
|