Pavel Labath ba95a28c18 Log: Fix race in accessing the stream variable ...

Summary:
The code was attempting to copy the shared pointer member in order to
guarantee atomicity, but this is not enough. Instead, protect the
pointer with a proper read-write mutex.

This bug was present here for a long time, but my recent refactors must
have altered the timings slightly, such that now this fails fairly often
when running the tests: the test runner runs the "log disable" command
just as the thread monitoring the lldb-server child is about to report
that the server has exited.

I add a test case for this. It's not possible to reproduce the race
deterministically in normal circumstances, but I have verified that
before the fix, the test failed when run under tsan, and was running
fine afterwards.

Reviewers: clayborg, zturner

Subscribers: lldb-commits

Differential Revision: https://reviews.llvm.org/D30168

llvm-svn: 295712

2017-02-21 09:58:23 +00:00

..

API

[CMake] Adding API dependency on Utility

2017-02-13 21:16:01 +00:00

Breakpoint

[CMake] Adding API dependency on Utility

2017-02-13 21:19:53 +00:00

Commands

Fix a couple of corner cases in NameMatches

2017-02-20 11:35:33 +00:00

Core

Log: Fix race in accessing the stream variable

2017-02-21 09:58:23 +00:00

DataFormatters

Clean up debug logging

2017-02-13 11:03:17 +00:00

Expression

Remove dependencies from Utility to Core and Target.

2017-02-14 19:06:07 +00:00

Host

Finish breaking the dependency from Utility.

2017-02-16 19:38:21 +00:00

Initialization

…

Interpreter

Finish breaking the dependency from Utility.

2017-02-16 19:38:21 +00:00

Plugins

Fix spelling mistake.

2017-02-21 05:09:26 +00:00

Symbol

Fix compiler warnings for missing switch cases in lldb.

2017-02-17 13:39:50 +00:00

Target

Fix a couple of corner cases in NameMatches

2017-02-20 11:35:33 +00:00

Utility

Fix a couple of corner cases in NameMatches

2017-02-20 11:35:33 +00:00

CMakeLists.txt

…

lldb.cpp

…