mirror of
https://github.com/intel/llvm.git
synced 2026-01-13 19:08:21 +08:00
8b3af63b89
A lot of comments in LLDB are surrounded by an ASCII line to delimit the begging and end of the comment. Its use is not really consistent across the code base, sometimes the lines are longer, sometimes they are shorter and sometimes they are omitted. Furthermore, it looks kind of weird with the 80 column limit, where the comment actually extends past the line, but not by much. Furthermore, when /// is used for Doxygen comments, it looks particularly odd. And when // is used, it incorrectly gives the impression that it's actually a Doxygen comment. I assume these lines were added to improve distinguishing between comments and code. However, given that todays editors and IDEs do a great job at highlighting comments, I think it's worth to drop this for the sake of consistency. The alternative is fixing all the inconsistencies, which would create a lot more churn. Differential revision: https://reviews.llvm.org/D60508 llvm-svn: 358135
69 lines
2.5 KiB
C++
69 lines
2.5 KiB
C++
//===-- ThreadPlanCallFunctionUsingABI.cpp ----------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "lldb/Target/ThreadPlanCallFunctionUsingABI.h"
|
|
#include "lldb/Core/Address.h"
|
|
#include "lldb/Target/Process.h"
|
|
#include "lldb/Target/RegisterContext.h"
|
|
#include "lldb/Target/Target.h"
|
|
#include "lldb/Target/Thread.h"
|
|
#include "lldb/Utility/Log.h"
|
|
#include "lldb/Utility/Stream.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
|
|
// ThreadPlanCallFunctionUsingABI: Plan to call a single function using the ABI
|
|
// instead of JIT
|
|
ThreadPlanCallFunctionUsingABI::ThreadPlanCallFunctionUsingABI(
|
|
Thread &thread, const Address &function, llvm::Type &prototype,
|
|
llvm::Type &return_type, llvm::ArrayRef<ABI::CallArgument> args,
|
|
const EvaluateExpressionOptions &options)
|
|
: ThreadPlanCallFunction(thread, function, options),
|
|
m_return_type(return_type) {
|
|
lldb::addr_t start_load_addr = LLDB_INVALID_ADDRESS;
|
|
lldb::addr_t function_load_addr = LLDB_INVALID_ADDRESS;
|
|
ABI *abi = nullptr;
|
|
|
|
if (!ConstructorSetup(thread, abi, start_load_addr, function_load_addr))
|
|
return;
|
|
|
|
if (!abi->PrepareTrivialCall(thread, m_function_sp, function_load_addr,
|
|
start_load_addr, prototype, args))
|
|
return;
|
|
|
|
ReportRegisterState("ABI Function call was set up. Register state was:");
|
|
|
|
m_valid = true;
|
|
}
|
|
|
|
ThreadPlanCallFunctionUsingABI::~ThreadPlanCallFunctionUsingABI() = default;
|
|
|
|
void ThreadPlanCallFunctionUsingABI::GetDescription(Stream *s,
|
|
DescriptionLevel level) {
|
|
if (level == eDescriptionLevelBrief) {
|
|
s->Printf("Function call thread plan using ABI instead of JIT");
|
|
} else {
|
|
TargetSP target_sp(m_thread.CalculateTarget());
|
|
s->Printf("Thread plan to call 0x%" PRIx64 " using ABI instead of JIT",
|
|
m_function_addr.GetLoadAddress(target_sp.get()));
|
|
}
|
|
}
|
|
|
|
void ThreadPlanCallFunctionUsingABI::SetReturnValue() {
|
|
ProcessSP process_sp(m_thread.GetProcess());
|
|
const ABI *abi = process_sp ? process_sp->GetABI().get() : nullptr;
|
|
|
|
// Ask the abi for the return value
|
|
if (abi) {
|
|
const bool persistent = false;
|
|
m_return_valobj_sp =
|
|
abi->GetReturnValueObject(m_thread, m_return_type, persistent);
|
|
}
|
|
}
|