mirror of
https://github.com/intel/llvm.git
synced 2026-01-19 01:15:50 +08:00
bf6f3894c4
Summary: These warnings were present when building llvm-libc in release mode. ``` workspace/llvm-project/libc/utils/benchmarks/LibcMemoryBenchmarkTest.cpp:50:34: warning: 'None' is deprecated: Use Align() or Align(1) instead [-Wdeprecated-declarations] Conf.AddressAlignment = Align::None(); workspace/llvm-project/libc/utils/testutils/FDReaderUnix.cpp:19:7: warning: unused variable 'err' [-Wunused-variable] int err = ::pipe(pipefd); ``` For test-utils it seems in general we should use `report_fatal_error` instead of asserts as these are turned off when building in release mode. https://llvm.org/docs/CodingStandards.html#assert-liberally Reviewers: abrachet, sivachandra Reviewed By: abrachet, sivachandra Subscribers: tschuett, libc-commits Tags: #libc-project Differential Revision: https://reviews.llvm.org/D79469
42 lines
1.2 KiB
C++
42 lines
1.2 KiB
C++
//===-- FDReader.cpp ------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "FDReader.h"
|
|
#include "llvm/Support/MemoryBuffer.h"
|
|
#include <cassert>
|
|
#include <cstring>
|
|
#include <unistd.h>
|
|
|
|
namespace __llvm_libc {
|
|
namespace testutils {
|
|
|
|
FDReader::FDReader() {
|
|
if (::pipe(pipefd))
|
|
llvm::report_fatal_error("pipe(2) failed");
|
|
}
|
|
|
|
FDReader::~FDReader() {
|
|
::close(pipefd[0]);
|
|
::close(pipefd[1]);
|
|
}
|
|
|
|
bool FDReader::matchWritten(const char *str) {
|
|
llvm::ErrorOr<std::unique_ptr<llvm::MemoryBuffer>> bufOrErr =
|
|
llvm::MemoryBuffer::getOpenFile(pipefd[0], "<pipe>",
|
|
/* FileSize (irrelevant) */ 0);
|
|
if (!bufOrErr) {
|
|
assert(0 && "Error reading from pipe");
|
|
return false;
|
|
}
|
|
const llvm::MemoryBuffer &buf = **bufOrErr;
|
|
return !std::strncmp(buf.getBufferStart(), str, buf.getBufferSize());
|
|
}
|
|
|
|
} // namespace testutils
|
|
} // namespace __llvm_libc
|