Fariborz Jahanian b7859ddf9b [Sema]. Warn when logical expression is a pointer ...

which evaluates to true. rdar://18716393.
Reviewed by Richard Trieu

llvm-svn: 222009

2014-11-14 17:12:50 +00:00

..

diagnostics

[analyzer] Check for NULL passed to CFAutorelease.

2014-06-21 23:50:40 +00:00

engine

…

inlining

Do not inline methods of C++ containers (coming from headers).

2014-06-27 01:03:05 +00:00

Inputs

[analyzer] Fix pthread lock tests so that the API comes from a system header.

2014-09-10 16:17:42 +00:00

objc

Correct hyphenations in comments and assert messages

2013-12-05 04:47:09 +00:00

additive-folding-range-constraints.c

…

additive-folding.cpp

…

analyze_display_progress.c

…

analyzeOneFunction.m

…

analyzer-config.c

Revert "[analyzer] Add very limited support for temporary destructors"

2013-07-23 02:15:11 +00:00

analyzer-config.cpp

Revert "[analyzer] Add very limited support for temporary destructors"

2013-07-23 02:15:11 +00:00

analyzer-stats.c

Revert "Don't require -re suffix on -verify directives with regexes."

2013-12-14 01:07:05 +00:00

array-struct-region.c

…

array-struct-region.cpp

[analyzer] Add IdenticalExprChecker, to find copy-pasted code.

2013-11-08 01:15:39 +00:00

array-struct.c

…

auto-obj-dtors-cfg-output.cpp

Reapply "Pretty Printer: Fix printing of conversion operator decls and calls."

2014-02-25 18:03:55 +00:00

base-init.cpp

…

bitwise-ops.c

[analyzer] Shitfing a constant value by its bit width is undefined.

2014-01-16 18:02:23 +00:00

blocks-no-inline.c

…

blocks.m

[analyzer] Fix an infinite recursion in region invalidation by adding block count to the BlockDataRegion.

2013-11-20 00:11:42 +00:00

bool-assignment.c

Re-apply "[analyzer] Model casts to bool differently from other numbers."

2013-05-01 18:19:59 +00:00

bstring.c

[analyzer] Make CStringChecker correctly calculate return value of mempcpy

2014-10-03 21:48:54 +00:00

builtin-functions.cpp

Teach the analyzer that __builtin_assume_aligned returns its first argument.

2014-09-09 21:42:16 +00:00

call-invalidation.cpp

[analyzer] Functions marked __attribute__((const)) don't modify any memory.

2014-05-07 03:29:56 +00:00

casts.c

PR16074, implement warnings to catch pointer to boolean true and pointer to

2014-02-26 02:36:06 +00:00

casts.cpp

[analyzer] Fix test in previous commit to account for compiler warning.

2013-12-19 23:05:40 +00:00

casts.m

[analyzer] Weaken assertion to account for pointer-to-integer casts.

2013-07-25 17:22:02 +00:00

CFContainers-invalid.c

…

CFContainers.mm

…

CFDateGC.m

…

cfg.cpp

Fix some cases of incorrect handling of lifetime extended temporaries.

2014-07-30 08:34:42 +00:00

CFNumber.c

…

cfref_PR2519.c

…

cfref_rdar6080742.c

…

CFRetainRelease_NSAssertionHandler.m

…

CGColorSpace.c

…

check-deserialization.cpp

…

checker-plugins.c

Add a test for Static Analyzer checker plugins

2014-01-09 00:47:40 +00:00

CheckNSError.m

…

chroot.c

…

comparison-implicit-casts.cpp

…

complex-init-list.cpp

…

complex.c

…

concrete-address.c

…

conditional-operator.cpp

Switch %clang -cc1 tests to %clang_cc1

2013-10-28 23:47:09 +00:00

conditional-path-notes.c

[analyzer] Don't emit an "Assuming x is <OP> y" if it's not a comparison op.

2013-10-26 01:16:26 +00:00

constant-folding.c

…

coverage.c

[analyzer] Shorten the malloc checker’s leak message

2013-04-06 00:41:36 +00:00

crash-trace.c

Remove line number from test/Analysis/crash-trace.c.

2013-07-23 16:12:18 +00:00

cstring-syntax-cxx.cpp

[analyzer] Fix a crash in SyntaxCString checker when given a custom strncat.

2013-04-10 22:06:29 +00:00

cstring-syntax.c

…

ctor.mm

[analyzer] Improve test from r207486.

2014-04-29 17:08:17 +00:00

cxx11-crashes.cpp

Teach static analyzer about AttributedStmts

2013-07-02 09:38:48 +00:00

cxx-crashes.cpp

…

cxx-for-range-cfg.cpp

…

cxx-for-range.cpp

[analyzer] Specialize "loop executed 0 times" for for-in and for-range loops.

2013-11-08 01:15:30 +00:00

cxx-method-names.cpp

…

dead-stores.c

Consolidate header inclusion diagnostics

2014-07-11 20:53:51 +00:00

dead-stores.cpp

…

dead-stores.m

Teach DeadStoresChecker about attribute objc_precise_lifetime.

2014-01-15 00:59:23 +00:00

debug-CallGraph.c

…

default-analyze.m

Objective-C. After providing a fix-it for a

2013-12-18 21:04:43 +00:00

default-diagnostic-visitors.c

…

delegates.m

…

derived-to-base.cpp

Fix static analyzer crash when casting from an incomplete type

2013-06-20 07:45:01 +00:00

disable-all-checks.c

Fixup for r216763. Add a driver test.

2014-08-29 21:51:22 +00:00

div-zero.cpp

…

domtest.c

…

dtor-cxx11.cpp

[analyzer] Remove incorrect workaround for unimplemented temporary destructors.

2014-04-01 16:39:59 +00:00

dtor.cpp

[analyzer] Re-enable test I accidentally committed commented-out.

2014-04-07 16:36:08 +00:00

dtors-in-dtor-cfg-output.cpp

…

dynamic-cast.cpp

Fix a tranche of comment, test and doc typos

2013-12-05 16:25:25 +00:00

edges-new.mm

[analyzer] Specialize "loop executed 0 times" for for-in and for-range loops.

2013-11-08 01:15:30 +00:00

elementtype.c

…

enum.cpp

[analyzer] Replace isIntegerType() with isIntegerOrEnumerationType().

2013-04-09 02:30:33 +00:00

exceptions.mm

…

exercise-ps.c

Consolidate header inclusion diagnostics

2014-07-11 20:53:51 +00:00

fields.c

…

free.c

…

func.c

[analyzer] Add new debug helper clang_analyzer_warnIfReached.

2013-10-03 16:57:03 +00:00

global_region_invalidation.mm

[analyzer] Re-enable using global regions as a symbolic base.

2013-04-15 20:39:45 +00:00

global-region-invalidation.c

[analyzer] Re-enable using global regions as a symbolic base.

2013-04-15 20:39:45 +00:00

html-diags-multifile.c

Fix test that wasn't testing anything

2013-11-05 12:45:37 +00:00

html-diags-multifile.h

…

html-diags.c

Add a test case for r185707/PR16547.

2013-07-05 15:51:00 +00:00

identical-expressions.cpp

[test] Turn off warnings for test/Analysis/identical-expressions.cpp.

2014-08-20 22:40:57 +00:00

initializer.cpp

[analyzer] Handle C++11 member initializer expressions.

2013-07-17 17:16:42 +00:00

initializers-cfg-output.cpp

CFG: Properly print delegating initializer CFG elements.

2013-10-22 23:19:47 +00:00

inline2.c

…

inline3.c

…

inline4.c

…

inline-not-supported.c

…

inline-plist.c

[analyzer] Enable the new edge algorithm by default.

2013-06-03 23:00:19 +00:00

inline-unique-reports.c

[analyzer] Enable the new edge algorithm by default.

2013-06-03 23:00:19 +00:00

inline.c

Fix a crash in the static analyzer (bug #16307)

2013-06-19 08:19:56 +00:00

inline.cpp

[analyzer] Inline C++ operator new when c++-inline-allocators is turned on.

2014-02-11 02:21:06 +00:00

ivars.m

…

keychainAPI-diagnostic-visitor.m

…

keychainAPI.m

…

kmalloc-linux.c

[analyzer] Handle the M_ZERO and __GFP_ZERO flags in kernel mallocs.

2014-03-26 17:05:46 +00:00

lambdas.cpp

Per latest drafting, switch to implementing init-captures as if by declaring

2013-09-28 04:02:39 +00:00

lit.local.cfg

Make the information about disabled ARCMT/Rewriter/StaticAnalyzer available

2013-08-27 19:27:35 +00:00

live-variables.cpp

Revert "[analyzer] Refactor conditional expression evaluating code"

2013-12-06 18:56:29 +00:00

live-variables.m

Revert "[analyzer] Refactor conditional expression evaluating code"

2013-12-06 18:56:29 +00:00

logical-ops.c

[Sema]. Warn when logical expression is a pointer

2014-11-14 17:12:50 +00:00

lvalue.cpp

…

malloc-annotations.c

[analyzer] Shorten the malloc checker’s leak message

2013-04-06 00:41:36 +00:00

malloc-interprocedural.c

[analyzer] Shorten the malloc checker’s leak message

2013-04-06 00:41:36 +00:00

malloc-overflow.c

…

malloc-overflow.cpp

…

malloc-plist.c

[analyzer] Enable the new edge algorithm by default.

2013-06-03 23:00:19 +00:00

malloc-protoype.c

[analyzer] Don't crash if malloc() has an unexpected function prototype.

2014-09-05 16:33:51 +00:00

malloc-sizeof.c

…

malloc-sizeof.cpp

[analyzer] Tweak MallocSizeOfChecker to not warn when using sizeof(void*) to allocate a bunch of any pointer type.

2014-10-19 07:30:55 +00:00

malloc-three-arg.c

[analyzer] Handle the M_ZERO and __GFP_ZERO flags in kernel mallocs.

2014-03-26 17:05:46 +00:00

malloc.c

[analyzer] Teach CastSizeChecker about flexible array members.

2014-02-18 17:06:30 +00:00

malloc.cpp

[analyzer] Consolidate constant evaluation logic in SValBuilder.

2013-05-01 23:10:44 +00:00

malloc.m

[analyzer] Pointers escape into +[NSValue valueWithPointer:]...

2014-01-07 21:39:48 +00:00

malloc.mm

[analyzer] Switched to checkPreCall interface for detecting usage after free.

2013-04-10 22:21:41 +00:00

Malloc+MismatchedDeallocator_intersections.cpp

…

Malloc+MismatchedDeallocator+NewDelete.cpp

[analyzer] Move the NewDeleteLeaks checker from CplusplusAlpha to Cplusplus package.

2014-10-21 12:41:36 +00:00

Malloc+NewDelete_intersections.cpp

[analyzer] Move the NewDeleteLeaks checker from CplusplusAlpha to Cplusplus package.

2014-10-21 12:41:36 +00:00

member-expr.cpp

[analyzer] Don't assert when combining using .* on a temporary.

2014-04-29 17:08:12 +00:00

method-arg-decay.m

Change 'method X in protocol not implemented' warning to include the name of the protocol.

2013-12-13 05:58:51 +00:00

method-call-intra-p.cpp

…

method-call-path-notes.cpp

[analyzer] Enable the new edge algorithm by default.

2013-06-03 23:00:19 +00:00

method-call.cpp

…

misc-ps-64.m

…

misc-ps-arm.m

Add error checking to reject neon_vector_type attribute on targets without NEON.

2013-09-16 18:07:35 +00:00

misc-ps-cxx0x.cpp

…

misc-ps-eager-assume.m

…

misc-ps-ranges.m

…

misc-ps-region-store-i386.m

…

misc-ps-region-store-x86_64.m

…

misc-ps-region-store.cpp

Add -Wtautological-undefined-compare and -Wundefined-bool-conversion warnings

2014-06-06 21:39:26 +00:00

misc-ps-region-store.m

Fix testcase for case.

2014-05-20 17:15:31 +00:00

misc-ps-region-store.mm

…

misc-ps.c

[analyzer] Accept references to variables declared "extern void" (C only).

2013-05-29 20:50:34 +00:00

misc-ps.m

[analyzer] Check for negative values used as the size of a C variable-length array.

2014-08-12 16:44:22 +00:00

MismatchedDeallocator-checker-test.mm

New message for cases when ownership is taken:

2013-09-16 17:51:25 +00:00

MismatchedDeallocator-path-notes.cpp

[analyzer] Enable the new edge algorithm by default.

2013-06-03 23:00:19 +00:00

MissingDealloc.m

…

model-file.cpp

Add support for the static analyzer to synthesize function implementations from external model files.

2014-08-27 15:14:15 +00:00

new-with-exceptions.cpp

[analyzer] Assume new returns non-null even under -fno-exceptions

2013-08-28 08:04:08 +00:00

new.cpp

Correct hyphenations in comments and assert messages

2013-12-05 04:47:09 +00:00

NewDelete-checker-test.cpp

[analyzer] Move the NewDeleteLeaks checker from CplusplusAlpha to Cplusplus package.

2014-10-21 12:41:36 +00:00

NewDelete-custom.cpp

[analyzer] Move the NewDeleteLeaks checker from CplusplusAlpha to Cplusplus package.

2014-10-21 12:41:36 +00:00

NewDelete-intersections.mm

[analyzer] Move the NewDeleteLeaks checker from CplusplusAlpha to Cplusplus package.

2014-10-21 12:41:36 +00:00

NewDelete-path-notes.cpp

[analyzer] Assume new returns non-null even under -fno-exceptions

2013-08-28 08:04:08 +00:00

NewDelete-variadic.cpp

[analyzer] Move the NewDeleteLeaks checker from CplusplusAlpha to Cplusplus package.

2014-10-21 12:41:36 +00:00

NewDelete+MismatchedDeallocator_intersections.cpp

[analyzer] Move the NewDeleteLeaks checker from CplusplusAlpha to Cplusplus package.

2014-10-21 12:41:36 +00:00

NewDeleteLeaks-PR18394.cpp

[analyzer] Move the NewDeleteLeaks checker from CplusplusAlpha to Cplusplus package.

2014-10-21 12:41:36 +00:00

NewDeleteLeaks-PR19102.cpp

[analyzer] Move the NewDeleteLeaks checker from CplusplusAlpha to Cplusplus package.

2014-10-21 12:41:36 +00:00

nil-receiver-undefined-larger-than-voidptr-ret-region.m

…

nil-receiver-undefined-larger-than-voidptr-ret.m

Fix FileCheck --check-prefix lines.

2013-08-12 12:51:05 +00:00

no-exit-cfg.c

…

no-outofbounds.c

[analyzer] Teach CastSizeChecker about flexible array members.

2014-02-18 17:06:30 +00:00

nonnull.m

[analyzer] Check all 'nonnull' attributes, not just the first one.

2014-10-13 19:38:02 +00:00

NoReturn.m

Switch this test from needlessly running the clang driver to directly

2014-01-15 09:07:56 +00:00

NSContainers.m

[Sema]. Warn when logical expression is a pointer

2014-11-14 17:12:50 +00:00

NSPanel.m

…

NSString.m

…

NSWindow.m

…

null-deref-path-notes.m

[analyzer] Enable the new edge algorithm by default.

2013-06-03 23:00:19 +00:00

null-deref-ps-region.c

…

null-deref-ps.c

[analyzer] Remove IdempotentOperations checker.

2014-01-04 05:52:11 +00:00

nullptr.cpp

[analyzer] Treat nullPtrType as a location type.

2013-07-12 17:58:33 +00:00

objc_invalidation.m

Objective-C [qoi]. If property is going to be implemented

2014-08-29 20:29:31 +00:00

objc-arc.m

Fix a tranche of comment, test and doc typos

2013-12-05 16:25:25 +00:00

objc-bool.m

…

objc-boxing.m

[Sema]. Warn when logical expression is a pointer

2014-11-14 17:12:50 +00:00

objc-for.m

Correct hyphenations in comments and assert messages

2013-12-05 04:47:09 +00:00

objc-method-coverage.m

…

objc-properties.m

Correct hyphenations in comments and assert messages

2013-12-05 04:47:09 +00:00

objc-radar17039661.m

Fix a crash in Retain Count checker error reporting

2014-06-13 23:47:38 +00:00

objc-string.mm

A new conversion warning for when an Objective-C object literal is implicitly

2014-01-28 23:40:26 +00:00

objc-subscript.m

[analyzer] RetainCountChecker: Clean up path notes for autorelease.

2013-04-23 01:42:25 +00:00

ObjCProperties.m

…

ObjCRetSigs.m

…

operator-calls.cpp

Sema: avoid reuse of Exprs when synthesizing operator=

2013-08-30 08:52:28 +00:00

OSAtomic_mac.cpp

…

out-of-bounds.c

[analyzer] Accept references to variables declared "extern void" (C only).

2013-05-29 20:50:34 +00:00

outofbound-notwork.c

…

outofbound.c

…

override-werror.c

…

plist-html-macros.c

…

plist-macros.cpp

[analyzer; alternate edges] Fix the edge locations in presence of macros.

2013-06-08 00:29:24 +00:00

plist-output-alternate.m

[analyzer] Enable the new edge algorithm by default.

2013-06-03 23:00:19 +00:00

plist-output.m

[analyzer] Enable the new edge algorithm by default.

2013-06-03 23:00:19 +00:00

pointer-to-member.cpp

[analyzer] Pointers-to-members are (currently) Locs, not NonLocs.

2013-07-02 16:50:24 +00:00

pr4209.m

…

PR2599.m

…

PR2978.m

…

PR3991.m

…

PR7218.c

…

PR9741.cpp

Remove duplicated -cc1 in tests

2013-12-08 18:06:52 +00:00

PR12905.c

…

pr_2542_rdar_6793404.m

…

pr_4164.c

…

properties.m

[analyzer] Don't track retain counts of objects directly accessed through ivars.

2014-03-25 17:10:58 +00:00

properties.mm

[analyzer] Tighten up sanity checks on Objective-C property getter synthesis.

2014-01-23 03:59:10 +00:00

pthreadlock.c

[analyzer] Fix pthread lock tests so that the API comes from a system header.

2014-09-10 16:17:42 +00:00

ptr-arith.c

PR16074, implement warnings to catch pointer to boolean true and pointer to

2014-02-26 02:36:06 +00:00

ptr-arith.cpp

[analyzer] Use a more generic MemRegion.getAsOffset to evaluate bin operators on MemRegions

2013-05-28 17:31:43 +00:00

rdar-6442306-1.m

…

rdar-6540084.m

improve of note message and minor refactoring of my last

2013-05-15 15:27:35 +00:00

rdar-6541136-region.c

…

rdar-6562655.m

…

rdar-6600344-nil-receiver-undefined-struct-ret.m

…

rdar-7168531.m

…

redefined_system.c

…

refcnt_naming.m

…

reference.cpp

Add -Wtautological-undefined-compare and -Wundefined-bool-conversion warnings

2014-06-06 21:39:26 +00:00

reference.mm

…

region-1.m

Objective-C. Diagose use of undefined protocols

2014-03-11 17:10:51 +00:00

region-store.c

…

region-store.cpp

…

reinterpret-cast.cpp

[analyzer] Re-enable reasoning about CK_LValueBitCast

2013-05-28 22:32:08 +00:00

retain-release-cache-out.m

[analyzer] Don't create new PostStmt nodes if we don't have to.

2014-06-18 19:23:30 +00:00

retain-release-cf-audited.m

…

retain-release-gc-only.m

…

retain-release-inline.m

…

retain-release-path-notes-gc.m

[analyzer] Merge TextPathDiagnostics and ClangDiagPathDiagConsumer.

2013-08-16 01:06:30 +00:00

retain-release-path-notes.m

[analyzer] RetainCountChecker: add support for CFAutorelease.

2013-10-07 17:16:52 +00:00

retain-release-region-store.m

…

retain-release.m

[analyzer] Check for NULL passed to CFAutorelease.

2014-06-21 23:50:40 +00:00

retain-release.mm

[analyzer] Fix a crash in RetainCountChecker - we should not rely on CallEnter::getCallExpr to return non-NULL

2013-04-25 00:41:32 +00:00

security-syntax-checks-no-emit.c

…

security-syntax-checks.m

Check the canonical parameter type with getAs<>() in a static checker

2013-06-24 16:56:16 +00:00

self-init.m

Replace -fobjc-default-synthesize-properties with disable-objc-default-synthesize-properties.

2013-09-27 20:21:48 +00:00

shallow-mode.m

…

simple-stream-checks.c

[analyzer] Indirect invalidation counts as an escape for leak checkers.

2013-05-10 17:07:16 +00:00

sizeofpointer.c

…

stack-addr-ps.c

…

stack-addr-ps.cpp

Add -Wtautological-undefined-compare and -Wundefined-bool-conversion warnings

2014-06-06 21:39:26 +00:00

stack-block-returned.cpp

…

stackaddrleak.c

PR16074, implement warnings to catch pointer to boolean true and pointer to

2014-02-26 02:36:06 +00:00

static_local.m

…

stats.c

…

stream.c

…

string-fail.c

…

string.c

[analyzer] Assume that strings are no longer than SIZE_MAX/4.

2013-08-19 16:27:34 +00:00

superclass.m

[analyzer] Move checker alpha.osx.cocoa.MissingSuperCall out of alpha category.

2014-02-19 05:28:39 +00:00

svalbuilder-logic.c

Re-apply "[analyzer] Model casts to bool differently from other numbers."

2013-05-01 18:19:59 +00:00

taint-generic.c

…

taint-tester.c

[analyzer] Tests: move system functions into system header simulator files.

2013-04-15 20:39:37 +00:00

taint-tester.cpp

[analyzer] Treat the rvalue of a forward-declared struct as Unknown.

2013-08-30 19:17:26 +00:00

taint-tester.m

…

temp-obj-dtors-cfg-output.cpp

Re-applying r214962.

2014-08-07 10:42:17 +00:00

templates.cpp

[analyzer] Don't crash if a block doesn't have a type signature.

2013-05-22 18:09:44 +00:00

temporaries.cpp

Work around missing handling of temporaries bound to default arguments.

2014-08-13 15:25:55 +00:00

test-after-div-zero.c

[analyzer] Check for code testing a variable for 0 after using it as a denominator.

2014-07-10 16:10:52 +00:00

test-objc-non-nil-return-value-checker.m

…

test-variably-modified-types.c

…

traversal-algorithm.mm

…

traversal-path-unification.c

…

undef-buffers.c

…

uninit-const.c

[analyzer] Warn when passing pointers to const but uninitialized memory.

2014-03-13 17:55:39 +00:00

uninit-const.cpp

[analyzer] Warn when passing pointers to const but uninitialized memory.

2014-03-13 17:55:39 +00:00

uninit-msg-expr.m

…

uninit-ps-rdar6145427.m

…

uninit-sometimes.cpp

PR16054: Slight strengthening for -Wsometimes-uninitialized: if we use a

2013-09-12 18:49:10 +00:00

uninit-vals-ps-region.m

[analyzer] Remove IdempotentOperations checker.

2014-01-04 05:52:11 +00:00

uninit-vals-ps.c

[analyzer] Don't warn for returning void expressions in void blocks.

2013-04-17 18:03:48 +00:00

uninit-vals.m

[analyzer] "Force" LazyCompoundVals on bind when they are simple enough.

2013-04-18 16:33:46 +00:00

unions-region.m

…

unions.cpp

[analyzer] Generate a LazyCompoundVal when loading from a union-typed region.

2013-10-23 20:08:55 +00:00

unix-api.c

[analyzer] UnixAPI: Check that the third argument to open(2) (if present) is an integer.

2014-08-20 16:58:09 +00:00

unix-fns.c

[analyzer] Address Jordan’s code review for r183451

2013-06-06 22:32:11 +00:00

unreachable-code-path.c

[analyzer] Don't run unreachable code checker on inlined functions.

2013-08-19 17:03:12 +00:00

unused-ivars.m

…

variadic-method-types.m

…

virtualcall.cpp

[analyzer] Don't warn on virtual calls in ctors to final methods.

2014-08-21 10:25:03 +00:00

virtualcall.h

…

vla.c

[analyzer] Check for negative values used as the size of a C variable-length array.

2014-08-12 16:44:22 +00:00

weak-functions.c

PR16074, implement warnings to catch pointer to boolean true and pointer to

2014-02-26 02:36:06 +00:00