api: remove getDisplayNames

Change-Id: If641609b25cf6dad1a2c91fe534c2fa3a7119ad1

bin/dbus/cx.ring.Ring.CallManager.xml

@@ -807,23 +807,6 @@
             </arg>
         </signal>
 
-        <method name="getDisplayNames" tp:name-for-bindings="getDisplayNames">
-            <tp:added version="1.3.0"/>
-            <tp:docstring>
-              Get the display name of every participant in a given conference, or their number as a fallback.
-            </tp:docstring>
-            <arg type="s" name="confID" direction="in">
-              <tp:docstring>
-                The conference ID.
-              </tp:docstring>
-            </arg>
-            <arg type="as" name="list" direction="out">
-              <tp:docstring>
-                The list of the display names.
-              </tp:docstring>
-            </arg>
-        </method>
-
         <method name="getParticipantList" tp:name-for-bindings="getParticipantList">
             <tp:added version="0.9.7"/>
             <tp:docstring>

bin/dbus/dbuscallmanager.cpp

@@ -252,13 +252,6 @@ DBusCallManager::getParticipantList(const std::string& confID)
     return DRing::getParticipantList(confID);
 }
 
-auto
-DBusCallManager::getDisplayNames(const std::string& confID)
-    -> decltype(DRing::getDisplayNames(confID))
-{
-    return DRing::getDisplayNames(confID);
-}
-
 auto
 DBusCallManager::getConferenceId(const std::string& callID)
     -> decltype(DRing::getConferenceId(callID))

bin/dbus/dbuscallmanager.h

@@ -97,7 +97,6 @@ public:
     bool unholdConference(const std::string& confID);
     std::vector<std::string> getConferenceList();
     std::vector<std::string> getParticipantList(const std::string& confID);
-    std::vector<std::string> getDisplayNames(const std::string& confID);
     std::string getConferenceId(const std::string& callID);
     std::map<std::string, std::string> getConferenceDetails(const std::string& callID);
     bool startRecordedFilePlayback(const std::string& filepath);

bin/jni/callmanager.i

@@ -99,7 +99,6 @@ bool holdConference(const std::string& confID);
 bool unholdConference(const std::string& confID);
 std::vector<std::string> getConferenceList();
 std::vector<std::string> getParticipantList(const std::string& confID);
-std::vector<std::string> getDisplayNames(const std::string& confID);
 std::string getConferenceId(const std::string& callID);
 std::map<std::string, std::string> getConferenceDetails(const std::string& callID);
 std::vector<std::map<std::string, std::string>> getConferenceInfos(const std::string& confId);

bin/nodejs/callmanager.i

@@ -90,7 +90,6 @@ bool holdConference(const std::string& confID);
 bool unholdConference(const std::string& confID);
 std::vector<std::string> getConferenceList();
 std::vector<std::string> getParticipantList(const std::string& confID);
-std::vector<std::string> getDisplayNames(const std::string& confID);
 std::string getConferenceId(const std::string& callID);
 std::map<std::string, std::string> getConferenceDetails(const std::string& callID);
 std::vector<std::map<std::string, std::string>> getConferenceInfos(const std::string& confId);

src/client/callmanager.cpp

@@ -262,12 +262,6 @@ getParticipantList(const std::string& confID)
     return jami::Manager::instance().getParticipantList(confID);
 }
 
-std::vector<std::string>
-getDisplayNames(const std::string& confID)
-{
-    return jami::Manager::instance().getDisplayNames(confID);
-}
-
 std::string
 getConferenceId(const std::string& callID)
 {

src/conference.cpp

@@ -717,20 +717,6 @@ Conference::getParticipantList() const
     return participants_;
 }
 
-std::vector<std::string>
-Conference::getDisplayNames() const
-{
-    std::vector<std::string> result;
-    result.reserve(participants_.size());
-
-    for (const auto& p : participants_) {
-        auto details = Manager::instance().getCallDetails(p);
-        const auto tmp = details["DISPLAY_NAME"];
-        result.emplace_back(tmp.empty() ? details["PEER_NUMBER"] : tmp);
-    }
-    return result;
-}
-
 bool
 Conference::toggleRecording()
 {

src/conference.h

@@ -288,11 +288,6 @@ public:
      */
     const ParticipantSet& getParticipantList() const;
 
-    /**
-     * Get the display names or peer numbers for this conference
-     */
-    std::vector<std::string> getDisplayNames() const;
-
     /**
      * Start/stop recording toggle
      */

src/jami/callmanager_interface.h

@@ -87,7 +87,6 @@ DRING_PUBLIC bool holdConference(const std::string& confID);
 DRING_PUBLIC bool unholdConference(const std::string& confID);
 DRING_PUBLIC std::vector<std::string> getConferenceList();
 DRING_PUBLIC std::vector<std::string> getParticipantList(const std::string& confID);
-DRING_PUBLIC std::vector<std::string> getDisplayNames(const std::string& confID);
 DRING_PUBLIC std::string getConferenceId(const std::string& callID);
 DRING_PUBLIC std::map<std::string, std::string> getConferenceDetails(const std::string& callID);
 DRING_PUBLIC std::vector<std::map<std::string, std::string>> getConferenceInfos(

src/manager.cpp

@@ -3195,15 +3195,6 @@ Manager::getConferenceList() const
     return map_utils::extractKeys(pimpl_->conferenceMap_);
 }
 
-std::vector<std::string>
-Manager::getDisplayNames(const std::string& confID) const
-{
-    if (auto conf = getConferenceFromID(confID))
-        return conf->getDisplayNames();
-    JAMI_WARN("Did not find conference %s", confID.c_str());
-    return {};
-}
-
 std::vector<std::string>
 Manager::getParticipantList(const std::string& confID) const
 {

src/manager.h

@@ -552,12 +552,6 @@ public:
      */
     std::vector<std::string> getParticipantList(const std::string& confID) const;
 
-    /**
-     * Get a list of the display names for everyone in a conference
-     * @return std::vector<std::string> A list of display names
-     */
-    std::vector<std::string> getDisplayNames(const std::string& confID) const;
-
     std::string getConferenceId(const std::string& callID);
 
     /**