Media/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2025-09-15 13:01:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove default parameter.

Browse Source 
Change-Id: I7da92801c7fa45b66bb7d770154d901bd3af9f5c
This commit is contained in:
Mrozek, Michal
2018-06-28 13:20:03 +02:00
committed by sys_ocldev
parent 561cdb7df5
commit 415623b08f
4 changed files with 13 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
runtime/device/device.h
View File

@ -53,11 +53,10 @@ class Device : public BaseObject<_cl_device_id> {
static const cl_ulong objectMagic = 0x8055832341AC8D08LL;
template <typename T>
static T *create(const HardwareInfo *pHwInfo,
bool isRootDevice = true) {
static T *create(const HardwareInfo *pHwInfo) {
pHwInfo = getDeviceInitHwInfo(pHwInfo);
T *device = new T(*pHwInfo);
if (false == createDeviceImpl(pHwInfo, isRootDevice, *device)) {
if (false == createDeviceImpl(pHwInfo, true, *device)) {
delete device;
return nullptr;
}

2
unit_tests/fixtures/preemption_fixture.cpp
View File

@ -50,7 +50,7 @@ void DevicePreemptionTests::SetUp() {
}
const cl_queue_properties properties[3] = {CL_QUEUE_PROPERTIES, 0, 0};
kernelInfo.reset(KernelInfo::create());
device.reset(MockDevice::create<OCLRT::MockDevice>(nullptr, false));
device.reset(MockDevice::create<OCLRT::MockDevice>(nullptr));
context.reset(new MockContext(device.get()));
cmdQ.reset(new MockCommandQueue(context.get(), device.get(), properties));
executionEnvironment.reset(new SPatchExecutionEnvironment);

18
unit_tests/os_interface/debug_settings_manager_tests.cpp
View File

@ -399,7 +399,7 @@ TEST(DebugSettingsManager, WithDebugFunctionalityDontDumpKernelArgsForNullMdi) {
TEST(DebugSettingsManager, WithDebugFunctionalityDumpKernelArgsForMdi) {
MockProgram program;
auto kernelInfo = unique_ptr<KernelInfo>(KernelInfo::create());
auto device = unique_ptr<Device>(Device::create<OCLRT::Device>(nullptr, false));
auto device = unique_ptr<Device>(Device::create<OCLRT::Device>(nullptr));
auto kernel = unique_ptr<MockKernel>(new MockKernel(&program, *kernelInfo, *device));
auto multiDispatchInfo = unique_ptr<MockMultiDispatchInfo>(new MockMultiDispatchInfo(kernel.get()));
@ -441,7 +441,7 @@ TEST(DebugSettingsManager, WithDebugFunctionalityDumpKernelNullKernel) {
TEST(DebugSettingsManager, WithDebugFunctionalityAndEmptyKernelDontDumpKernelArgs) {
MockProgram program;
auto kernelInfo = unique_ptr<KernelInfo>(KernelInfo::create());
auto device = unique_ptr<Device>(Device::create<OCLRT::Device>(nullptr, false));
auto device = unique_ptr<Device>(Device::create<OCLRT::Device>(nullptr));
auto kernel = unique_ptr<MockKernel>(new MockKernel(&program, *kernelInfo, *device));
FullyEnabledTestDebugManager debugManager;
@ -455,7 +455,7 @@ TEST(DebugSettingsManager, WithDebugFunctionalityAndEmptyKernelDontDumpKernelArg
TEST(DebugSettingsManager, WithDebugFunctionalityDumpKernelArgsImmediate) {
MockProgram program;
auto kernelInfo = unique_ptr<KernelInfo>(KernelInfo::create());
auto device = unique_ptr<Device>(Device::create<OCLRT::Device>(nullptr, false));
auto device = unique_ptr<Device>(Device::create<OCLRT::Device>(nullptr));
auto kernel = unique_ptr<MockKernel>(new MockKernel(&program, *kernelInfo, *device));
KernelArgPatchInfo kernelArgPatchInfo;
@ -486,7 +486,7 @@ TEST(DebugSettingsManager, WithDebugFunctionalityDumpKernelArgsImmediate) {
TEST(DebugSettingsManager, WithDebugFunctionalityDumpKernelArgsImmediateZeroSize) {
MockProgram program;
auto kernelInfo = unique_ptr<KernelInfo>(KernelInfo::create());
auto device = unique_ptr<Device>(Device::create<OCLRT::Device>(nullptr, false));
auto device = unique_ptr<Device>(Device::create<OCLRT::Device>(nullptr));
auto kernel = unique_ptr<MockKernel>(new MockKernel(&program, *kernelInfo, *device));
KernelArgPatchInfo kernelArgPatchInfo;
@ -514,7 +514,7 @@ TEST(DebugSettingsManager, WithDebugFunctionalityDumpKernelArgsImmediateZeroSize
TEST(DebugSettingsManager, WithDebugFunctionalityDumpKernelArgsLocalBuffer) {
MockProgram program;
auto kernelInfo = unique_ptr<KernelInfo>(KernelInfo::create());
auto device = unique_ptr<Device>(Device::create<OCLRT::Device>(nullptr, false));
auto device = unique_ptr<Device>(Device::create<OCLRT::Device>(nullptr));
auto kernel = unique_ptr<MockKernel>(new MockKernel(&program, *kernelInfo, *device));
KernelArgPatchInfo kernelArgPatchInfo;
@ -535,7 +535,7 @@ TEST(DebugSettingsManager, WithDebugFunctionalityDumpKernelArgsLocalBuffer) {
TEST(DebugSettingsManager, WithDebugFunctionalityDumpKernelArgsBufferNotSet) {
MockProgram program;
auto kernelInfo = unique_ptr<KernelInfo>(KernelInfo::create());
auto device = unique_ptr<Device>(Device::create<OCLRT::Device>(nullptr, false));
auto device = unique_ptr<Device>(Device::create<OCLRT::Device>(nullptr));
auto kernel = unique_ptr<MockKernel>(new MockKernel(&program, *kernelInfo, *device));
KernelArgPatchInfo kernelArgPatchInfo;
@ -566,7 +566,7 @@ TEST(DebugSettingsManager, WithDebugFunctionalityDumpKernelArgsBuffer) {
MockProgram program(&context, false);
auto kernelInfo = unique_ptr<KernelInfo>(KernelInfo::create());
auto device = unique_ptr<Device>(Device::create<OCLRT::Device>(nullptr, false));
auto device = unique_ptr<Device>(Device::create<OCLRT::Device>(nullptr));
auto kernel = unique_ptr<MockKernel>(new MockKernel(&program, *kernelInfo, *device));
KernelArgPatchInfo kernelArgPatchInfo;
@ -600,7 +600,7 @@ TEST(DebugSettingsManager, WithDebugFunctionalityDumpKernelArgsBuffer) {
TEST(DebugSettingsManager, WithDebugFunctionalityDumpKernelArgsSampler) {
MockProgram program;
auto kernelInfo = unique_ptr<KernelInfo>(KernelInfo::create());
auto device = unique_ptr<Device>(Device::create<OCLRT::Device>(nullptr, false));
auto device = unique_ptr<Device>(Device::create<OCLRT::Device>(nullptr));
auto kernel = unique_ptr<MockKernel>(new MockKernel(&program, *kernelInfo, *device));
KernelArgPatchInfo kernelArgPatchInfo;
@ -623,7 +623,7 @@ TEST(DebugSettingsManager, WithDebugFunctionalityDumpKernelArgsSampler) {
TEST(DebugSettingsManager, WithDebugFunctionalityDumpKernelArgsImageNotSet) {
MockProgram program;
auto kernelInfo = unique_ptr<KernelInfo>(KernelInfo::create());
auto device = unique_ptr<Device>(Device::create<OCLRT::Device>(nullptr, false));
auto device = unique_ptr<Device>(Device::create<OCLRT::Device>(nullptr));
auto kernel = unique_ptr<MockKernel>(new MockKernel(&program, *kernelInfo, *device));
SKernelBinaryHeaderCommon kernelHeader;

2
unit_tests/program/printf_helper_tests.cpp
View File

@ -59,7 +59,7 @@ class PrintFormatterTest : public testing::Test {
data = new MockGraphicsAllocation(underlyingBuffer, PrintFormatter::maxPrintfOutputLength);
kernelInfo = KernelInfo::create();
device = Device::create<OCLRT::Device>(nullptr, false);
device = Device::create<OCLRT::Device>(nullptr);
kernel = new MockKernel(&program, *kernelInfo, *device);
printFormatter = new PrintFormatter(*kernel, *data);