Popup : Close all popups by pressing escape

Using a key OnPressed instead of Shortcut
Making all popups closable with escape (focus true and a close policy)

GitLab: #1234
Change-Id: I1a612834c439aea94a59e91cb915b18b4ef5cf84

src/app/commoncomponents/BaseModalDialog.qml

@@ -47,6 +47,7 @@ Popup {
 
     // A popup is invisible until opened.
     visible: false
+    focus: true
     closePolicy: autoClose ? (Popup.CloseOnEscape | Popup.CloseOnPressOutside) : Popup.NoAutoClose
 
     Rectangle {

src/app/commoncomponents/EmojiReactionPopup.qml

@@ -42,6 +42,7 @@ Popup {
     padding: 0
 
     visible: false
+    focus: true
     closePolicy: Popup.CloseOnEscape | Popup.CloseOnPressOutside
 
     Rectangle {

src/app/commoncomponents/MarkdownPopup.qml

@@ -30,6 +30,9 @@ Popup {
     padding: 0
     property list<Action> menuTypoActionsSecond
 
+    focus: true
+    closePolicy: Popup.CloseOnEscape | Popup.CloseOnPressOutside
+
     contentItem: ListView {
         id: listViewTypoSecond
 

src/app/commoncomponents/MessageOptionsPopup.qml

@@ -49,6 +49,9 @@ Popup {
     property bool closeWithoutAnimation: false
     property var emojiPicker
 
+    focus: true
+    closePolicy: Popup.CloseOnEscape | Popup.CloseOnPressOutside
+
     function xPositionProvider(width) {
         // Use the width at function scope to retrigger property evaluation.
         const listViewWidth = listView.width

src/app/mainview/MainView.qml

@@ -149,13 +149,12 @@ Rectangle {
         onActivated: layoutManager.toggleWindowFullScreen()
     }
 
-    Shortcut {
-        sequence: "Escape"
-        context: Qt.ApplicationShortcut
-        onActivated: {
-            MessagesAdapter.replyToId = ""
-            MessagesAdapter.editId = ""
-            layoutManager.popFullScreenItem()
+    Keys.onPressed: function (keyEvent) {
+        if (keyEvent.key === Qt.Key_Escape) {
+            MessagesAdapter.replyToId = "";
+            MessagesAdapter.editId = "";
+            layoutManager.popFullScreenItem();
+            keyEvent.accepted = true;
         }
     }
 

src/app/mainview/components/AccountComboBoxPopup.qml

@@ -40,6 +40,9 @@ Popup {
         color: JamiTheme.transparentColor
     }
 
+    focus: true
+    closePolicy: Popup.CloseOnEscape | Popup.CloseOnPressOutside
+
     contentItem: ColumnLayout {
         spacing: 0
 

src/app/mainview/components/ChatViewFooter.qml

@@ -220,10 +220,7 @@ Rectangle {
 
             Keys.onShortcutOverride: function (keyEvent) {
                 if (keyEvent.key === Qt.Key_Escape) {
-                    if (emojiPicker != null && emojiPicker.opened) {
-                        emojiPicker.closeEmojiPicker();
-                    }
-                    else if (recordBox != null && recordBox.opened) {
+                    if (recordBox != null && recordBox.opened) {
                         recordBox.closeRecorder();
                     }
                     else if (PositionManager.isMapActive(CurrentAccount.id)){

src/app/mainview/components/RecordBox.qml

@@ -51,6 +51,9 @@ Popup {
 
     signal validatePhoto(string photo)
 
+    modal: true
+    closePolicy: Popup.CloseOnPressOutsideParent
+
     function openRecorder(vid) {
         isVideo = vid;
         updateState(RecordBox.States.INIT);
@@ -121,9 +124,6 @@ Popup {
         time.text = min + ":" + sec;
     }
 
-    modal: true
-    closePolicy: Popup.CloseOnEscape | Popup.CloseOnPressOutsideParent
-
     onActiveFocusChanged: {
         if (visible) {
             closeRecorder();

src/app/webengine/emojipicker/EmojiPicker.qml

@@ -32,6 +32,9 @@ Popup {
     required property ListView listView
     signal emojiIsPicked(string content)
 
+    focus: true
+    closePolicy: Popup.CloseOnEscape | Popup.CloseOnPressOutsideParent
+
     // Close the picker when attached to a listView that receives height/scroll
     // property changes.
     property real listViewHeight: listView ? listView.height : 0

src/app/webengine/map/StopSharingPositionPopup.qml

@@ -42,6 +42,7 @@ Popup {
     padding: 0
 
     visible: false
+    focus: true
     closePolicy: Popup.CloseOnEscape | Popup.CloseOnPressOutside
     Rectangle {
         id: container

src/app/wizardview/components/NoUsernamePopup.qml

@@ -42,6 +42,7 @@ Popup {
     padding: 0
 
     visible: false
+    focus: true
     closePolicy: Popup.CloseOnEscape | Popup.CloseOnPressOutside
 
     Rectangle {