intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2025-12-20 08:53:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

Change the error checking in checkExtraMemFlagsForBuffer

Browse Source 
Change-Id: I598b5789c567a398c75355813a44ea647ff6cd0d
This commit is contained in:
Mrozek, Michal
2018-09-21 11:24:13 -07:00
committed by sys_ocldev
parent 83f733fb70
commit 328ecae57d
3 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
runtime/mem_obj/mem_obj_helper.cpp
View File

@@ -10,7 +10,7 @@
namespace OCLRT {
bool MemObjHelper::checkExtraMemFlagsForBuffer(cl_mem_flags flags) {
return true;
return false;
}
AllocationFlags MemObjHelper::getAllocationFlags(cl_mem_flags flags) {

2
runtime/mem_obj/mem_obj_helper.h
View File

@@ -21,7 +21,7 @@ class MemObjHelper {
CL_MEM_HOST_WRITE_ONLY | CL_MEM_HOST_READ_ONLY | CL_MEM_HOST_NO_ACCESS;
bool flagsValidated = (flags & (~allValidFlags)) == 0;
flagsValidated &= checkExtraMemFlagsForBuffer(flags & (~allValidFlags));
flagsValidated |= checkExtraMemFlagsForBuffer(flags & (~allValidFlags));
return flagsValidated;
}

6
unit_tests/mem_obj/mem_obj_helper_tests.cpp
View File

@@ -20,10 +20,8 @@ TEST(MemObjHelper, givenValidMemFlagsForBufferWhenFlagsAreCheckedThenTrueIsRetur
TEST(MemObjHelper, givenInvalidMemFlagsForBufferWhenFlagsAreCheckedThenFalseIsReturned) {
cl_mem_flags flags = (1 << 13) | (1 << 14) | (1 << 30) | (1 << 31);
if (MemObjHelper::checkExtraMemFlagsForBuffer(flags)) {
EXPECT_FALSE(MemObjHelper::checkMemFlagsForBuffer(flags));
}
EXPECT_FALSE(MemObjHelper::checkExtraMemFlagsForBuffer(flags));
EXPECT_FALSE(MemObjHelper::checkMemFlagsForBuffer(flags));
}
TEST(MemObjHelper, givenValidMemFlagsForSubBufferWhenFlagsAreCheckedThenTrueIsReturned) {