intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2025-12-29 09:03:14 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(sysman): do not leak/exhaust memory with telemetry allocations

Browse Source 
Related-To: NEO-11825
Signed-off-by: Maciej Bielski <maciej.bielski@intel.com>
This commit is contained in:
Maciej Bielski
2024-07-29 11:21:49 +00:00
committed by Compute-Runtime-Automation
parent 2d1d74cf38
commit 44d6b5ebac
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
level_zero/sysman/source/shared/windows/pmt/sysman_pmt.cpp
View File

@@ -75,13 +75,16 @@ ze_result_t PlatformMonitoringTech::readValue(const std::string &key, uint64_t &
}
ze_result_t PlatformMonitoringTech::getGuid() {
// arbitrary upper-bound, tune if needed
constexpr size_t sizeNeededMax = sizeof(PmtSysman::PmtTelemetryDiscovery) + (2 * PmtSysman::PmtMaxInterfaces - 1) * sizeof(PmtSysman::PmtTelemetryEntry);
ze_result_t status;
unsigned long sizeNeeded;
PmtSysman::PmtTelemetryDiscovery *telemetryDiscovery = nullptr;
// Get Telmetry Discovery size
status = ioctlReadWriteData(deviceInterface, PmtSysman::IoctlPmtGetTelemetryDiscoverySize, NULL, 0, (void *)&sizeNeeded, sizeof(sizeNeeded), NULL);
if (status != ZE_RESULT_SUCCESS || sizeNeeded == 0) {
if (status != ZE_RESULT_SUCCESS || sizeNeeded == 0 || sizeNeeded > sizeNeededMax) {
NEO::printDebugString(NEO::debugManager.flags.PrintDebugMessages.get(), stderr,
"Ioctl call could not return a valid value for the PMT interface telemetry size needed\n");
DEBUG_BREAK_IF(true);
@@ -98,14 +101,15 @@ ze_result_t PlatformMonitoringTech::getGuid() {
if (status != ZE_RESULT_SUCCESS) {
NEO::printDebugString(NEO::debugManager.flags.PrintDebugMessages.get(), stderr,
"Ioctl call could not return a valid value for the PMT telemetry structure which provides the guids supported.\n");
DEBUG_BREAK_IF(true);
heapFreeFunction(GetProcessHeap(), 0, telemetryDiscovery);
DEBUG_BREAK_IF(true);
return ZE_RESULT_ERROR_UNKNOWN;
}
auto maxEntriesCount = (sizeNeeded - offsetof(PmtSysman::PmtTelemetryDiscovery, telemetry)) / sizeof(PmtSysman::PmtTelemetryEntry);
if (telemetryDiscovery->count > maxEntriesCount) {
NEO::printDebugString(NEO::debugManager.flags.PrintDebugMessages.get(), stderr, "Incorrect telemetry entries count.\n");
heapFreeFunction(GetProcessHeap(), 0, telemetryDiscovery);
DEBUG_BREAK_IF(true);
return ZE_RESULT_ERROR_UNKNOWN;
}
@@ -116,8 +120,8 @@ ze_result_t PlatformMonitoringTech::getGuid() {
} else {
NEO::printDebugString(NEO::debugManager.flags.PrintDebugMessages.get(), stderr,
"Telemetry index is out of range.\n");
DEBUG_BREAK_IF(true);
heapFreeFunction(GetProcessHeap(), 0, telemetryDiscovery);
DEBUG_BREAK_IF(true);
return ZE_RESULT_ERROR_UNKNOWN;
}
}