intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2025-12-29 17:13:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

feature(zebin): rename attribute to "require_iab"

Browse Source 
- implicit_arg_buffer_used_by_code is replaced with require_iab

Related-To: NEO-14667

Signed-off-by: Mateusz Hoppe <mateusz.hoppe@intel.com>
This commit is contained in:
Mateusz Hoppe
2025-05-26 14:15:55 +00:00
committed by Compute-Runtime-Automation
parent 31fe1978d4
commit 87e2114e42
3 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
shared/source/device_binary_format/zebin/zeinfo.h
View File

@@ -62,7 +62,7 @@ inline constexpr ConstStringRef workGroupWalkOrderDimensions("work_group_walk_or
inline constexpr ConstStringRef threadSchedulingMode("thread_scheduling_mode");
inline constexpr ConstStringRef hasSample("has_sample");
inline constexpr ConstStringRef actualKernelStartOffset("actual_kernel_start_offset");
inline constexpr ConstStringRef implicitArgBufferUsedByCode("implicit_arg_buffer_used_by_code");
inline constexpr ConstStringRef requireImplicitArgBuffer("require_iab");
namespace ThreadSchedulingMode {
inline constexpr ConstStringRef ageBased("age_based");
@@ -359,7 +359,7 @@ using SpillSizeT = int32_t;
using LocalRegionSizeT = int32_t;
using WalkOrderT = int32_t;
using PartitionDimT = int32_t;
using HasImplicitArgBufferUsedByCodeT = bool;
using RequireImplicitArgBufferT = bool;
namespace Defaults {
inline constexpr BarrierCountT barrierCount = 0;
@@ -394,7 +394,7 @@ inline constexpr SpillSizeT spillSize = 0;
inline constexpr LocalRegionSizeT localRegionSize = -1;
inline constexpr WalkOrderT dispatchWalkOrder = -1;
inline constexpr PartitionDimT partitionDim = -1;
inline constexpr HasImplicitArgBufferUsedByCodeT hasImplicitArgBufferUsedByCode = false;
inline constexpr RequireImplicitArgBufferT requireImplicitArgBuffer = false;
} // namespace Defaults
inline constexpr ConstStringRef required[] = {
@@ -445,7 +445,7 @@ struct ExecutionEnvBaseT final : NEO::NonCopyableAndNonMovableClass {
LocalRegionSizeT localRegionSize = Defaults::localRegionSize;
WalkOrderT dispatchWalkOrder = Defaults::dispatchWalkOrder;
PartitionDimT partitionDim = Defaults::partitionDim;
HasImplicitArgBufferUsedByCodeT hasImplicitArgBufferUsedByCode = Defaults::hasImplicitArgBufferUsedByCode;
RequireImplicitArgBufferT requireImplicitArgBuffer = Defaults::requireImplicitArgBuffer;
};
static_assert(NEO::NonCopyableAndNonMovable<ExecutionEnvBaseT>);

6
shared/source/device_binary_format/zebin/zeinfo_decoder.cpp
View File

@@ -686,8 +686,8 @@ DecodeError readZeInfoExecutionEnvironment(const Yaml::YamlParser &parser, const
validExecEnv &= readZeInfoValueChecked(parser, execEnvMetadataNd, outExecEnv.privateSize, context, outErrReason);
} else if (Tags::Kernel::ExecutionEnv::spillSize == key) {
validExecEnv &= readZeInfoValueChecked(parser, execEnvMetadataNd, outExecEnv.spillSize, context, outErrReason);
} else if (Tags::Kernel::ExecutionEnv::implicitArgBufferUsedByCode == key) {
validExecEnv &= readZeInfoValueChecked(parser, execEnvMetadataNd, outExecEnv.hasImplicitArgBufferUsedByCode, context, outErrReason);
} else if (Tags::Kernel::ExecutionEnv::requireImplicitArgBuffer == key) {
validExecEnv &= readZeInfoValueChecked(parser, execEnvMetadataNd, outExecEnv.requireImplicitArgBuffer, context, outErrReason);
} else if (Tags::Kernel::ExecutionEnv::actualKernelStartOffset == key) {
// ignore intentionally - deprecated and redundant key
} else {
@@ -720,7 +720,7 @@ void populateKernelExecutionEnvironment(KernelDescriptor &dst, const KernelExecu
dst.kernelAttributes.flags.usesSystolicPipelineSelectMode = execEnv.hasDpas;
dst.kernelAttributes.flags.usesStatelessWrites = (false == execEnv.hasNoStatelessWrite);
dst.kernelAttributes.flags.hasSample = execEnv.hasSample;
dst.kernelAttributes.flags.requiresImplicitArgs = execEnv.hasImplicitArgBufferUsedByCode;
dst.kernelAttributes.flags.requiresImplicitArgs = execEnv.requireImplicitArgBuffer;
dst.kernelAttributes.barrierCount = execEnv.barrierCount;
dst.kernelAttributes.bufferAddressingMode = (execEnv.has4GBBuffers) ? KernelDescriptor::Stateless : KernelDescriptor::BindfulAndStateless;
dst.kernelAttributes.inlineDataPayloadSize = static_cast<uint16_t>(execEnv.inlineDataPayloadSize);

8
shared/test/unit_test/device_binary_format/zebin_decoder_tests.cpp
View File

@@ -5400,13 +5400,13 @@ kernels:
EXPECT_TRUE(kernelDescriptor->kernelAttributes.flags.requiresImplicitArgs);
}
TEST_F(decodeZeInfoKernelEntryTest, GivenExecEnvImplicitArgBufferUsedByCodeTrueWhenPopulatingKernelDescriptorThenImplicitArgsAreRequired) {
TEST_F(decodeZeInfoKernelEntryTest, GivenExecEnvRequireImplicitArgBufferTrueWhenPopulatingKernelDescriptorThenImplicitArgsAreRequired) {
ConstStringRef zeinfo = R"===(
kernels:
- name : some_kernel
execution_env:
simd_size: 32
implicit_arg_buffer_used_by_code: true
require_iab: true
payload_arguments:
- arg_type: work_dimensions
offset: 32
@@ -5420,13 +5420,13 @@ kernels:
EXPECT_TRUE(kernelDescriptor->kernelAttributes.flags.requiresImplicitArgs);
}
TEST_F(decodeZeInfoKernelEntryTest, GivenExecEnvImplicitArgBufferUsedByCodeFalseWhenPopulatingKernelDescriptorThenImplicitArgsAreNotRequired) {
TEST_F(decodeZeInfoKernelEntryTest, GivenExecEnvRequireImplicitArgBufferFalseWhenPopulatingKernelDescriptorThenImplicitArgsAreNotRequired) {
ConstStringRef zeinfo = R"===(
kernels:
- name : some_kernel
execution_env:
simd_size: 32
implicit_arg_buffer_used_by_code: false
require_iab: false
payload_arguments:
- arg_type: work_dimensions
offset: 32