intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2025-12-19 06:24:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert "performance: enable timestamp caching on L0"

Browse Source 
This reverts commit 0fb04d3b52.

Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
This commit is contained in:
Compute-Runtime-Validation
2025-11-18 12:25:42 +01:00
committed by Compute-Runtime-Automation
parent 5b7def4c00
commit 8882b1e54a
4 changed files with 9 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
level_zero/core/source/event/event.cpp
View File

@@ -132,7 +132,6 @@ ze_result_t EventPool::initialize(DriverHandle *driver, Context *context, uint32
if (!allocatedMemory) {
NEO::AllocationProperties allocationProperties{*rootDeviceIndices.begin(), this->eventPoolSize, allocationType, neoDevice->getDeviceBitfield()};
allocationProperties.alignment = eventAlignment;
allocationProperties.flags.uncacheable = neoDevice->getProductHelper().isDcFlushAllowed();
auto memoryManager = driver->getMemoryManager();
auto graphicsAllocation = memoryManager->allocateGraphicsMemoryWithProperties(allocationProperties);
@@ -149,7 +148,6 @@ ze_result_t EventPool::initialize(DriverHandle *driver, Context *context, uint32
this->isHostVisibleEventPoolAllocation = true;
NEO::AllocationProperties allocationProperties{*rootDeviceIndices.begin(), this->eventPoolSize, allocationType, NEO::systemMemoryBitfield};
allocationProperties.alignment = eventAlignment;
allocationProperties.flags.uncacheable = neoDevice->getProductHelper().isDcFlushAllowed();
eventPoolPtr = driver->getMemoryManager()->createMultiGraphicsAllocationInSystemMemoryPool(rootDeviceIndices,
allocationProperties,

20
level_zero/core/test/unit_tests/sources/event/test_event.cpp
View File

@@ -3440,26 +3440,6 @@ TEST_F(EventPoolCreateSingleDevice, whenCreatingEventPoolWithNoDevicesThenEventP
EXPECT_EQ(allocation->getGraphicsAllocations().size(), 1u);
}
TEST_F(EventPoolCreateSingleDevice, whenCreatingEventPoolAndPlatformHasDcFlushThenEventPoolIsUncacheable) {
ze_event_pool_desc_t eventPoolDesc = {};
eventPoolDesc.stype = ZE_STRUCTURE_TYPE_EVENT_POOL_DESC;
eventPoolDesc.count = 1;
ze_result_t result = ZE_RESULT_SUCCESS;
std::unique_ptr<L0::EventPool> eventPool(EventPool::create(driverHandle.get(),
context,
0,
nullptr,
&eventPoolDesc,
result));
EXPECT_NE(nullptr, eventPool);
EXPECT_EQ(ZE_RESULT_SUCCESS, result);
auto allocation = &eventPool->getAllocation();
EXPECT_NE(nullptr, allocation);
auto mockAllocation = static_cast<MemoryAllocation *>(allocation->getGraphicsAllocations()[0]);
EXPECT_EQ(mockAllocation->uncacheable, device->getProductHelper().isDcFlushAllowed());
}
struct EventPoolCreateNegativeTest : public ::testing::Test {
void SetUp() override {

2
shared/source/os_interface/product_helper_xe2_and_later.inl
View File

@@ -59,7 +59,7 @@ bool ProductHelperHw<gfxProduct>::isNonCoherentTimestampsModeEnabled() const {
if (debugManager.flags.ForceNonCoherentModeForTimestamps.get() != -1) {
return debugManager.flags.ForceNonCoherentModeForTimestamps.get();
}
return true;
return !this->isDcFlushAllowed() || (ApiSpecificConfig::OCL == ApiSpecificConfig::getApiType());
}
template <PRODUCT_FAMILY gfxProduct>

9
shared/test/unit_test/helpers/gfx_core_helper_xe2_and_later.cpp
View File

@@ -35,7 +35,14 @@ HWTEST2_F(GfxCoreHelperXe2AndLaterTests, givenAtLeastXe2HpgWhenCallIsNonCoherent
MockExecutionEnvironment mockExecutionEnvironment{};
auto &productHelper = mockExecutionEnvironment.rootDeviceEnvironments[0]->getHelper<ProductHelper>();
EXPECT_TRUE(productHelper.isNonCoherentTimestampsModeEnabled());
{
VariableBackup<ApiSpecificConfig::ApiType> backup(&apiTypeForUlts, ApiSpecificConfig::OCL);
EXPECT_TRUE(productHelper.isNonCoherentTimestampsModeEnabled());
}
{
VariableBackup<ApiSpecificConfig::ApiType> backup(&apiTypeForUlts, ApiSpecificConfig::L0);
EXPECT_EQ(!productHelper.isDcFlushAllowed(), productHelper.isNonCoherentTimestampsModeEnabled());
}
}
HWTEST2_F(GfxCoreHelperXe2AndLaterTests, givenDebugFlagWhenCheckingIsResolveDependenciesByPipeControlsSupportedThenCorrectValueIsReturned, IsLNL) {