intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2025-12-20 08:53:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: sporadic in software tags test

Browse Source 
Related-To: NEO-9272

Signed-off-by: Konstanty Misiak <konstanty.misiak@intel.com>
This commit is contained in:
Konstanty Misiak
2023-11-06 18:30:26 +00:00
committed by Compute-Runtime-Automation
parent 10a97548c2
commit c160e6ff93
2 changed files with 22 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
shared/source/utilities/software_tags.cpp
View File

@@ -208,7 +208,11 @@ SWTagBXML::SWTagBXML() {
str = ss.str();
if (DebugManager.flags.DumpSWTagsBXML.get()) {
writeDataToFile("swtagsbxml_dump.xml", str.c_str(), str.size());
FILE *fp = NEO::IoFunctions::fopenPtr("swtagsbxml_dump.xml", "wb");
if (fp) {
NEO::IoFunctions::fwritePtr(str.c_str(), sizeof(char), str.size(), fp);
NEO::IoFunctions::fclosePtr(fp);
}
}
}

26
shared/test/unit_test/utilities/software_tags_manager_tests.cpp
View File

@@ -11,6 +11,7 @@
#include "shared/test/common/fixtures/device_fixture.h"
#include "shared/test/common/helpers/debug_manager_state_restore.h"
#include "shared/test/common/mocks/mock_device.h"
#include "shared/test/common/mocks/mock_io_functions.h"
#include "shared/test/common/test_macros/hw_test.h"
using namespace NEO;
@@ -258,14 +259,21 @@ TEST(SoftwareTagsBXMLTests, givenDumpSWTagsBXMLWhenConstructingBXMLThenAFileIsDu
DebugManagerStateRestore dbgRestorer;
DebugManager.flags.DumpSWTagsBXML.set(true);
const char *filename = "swtagsbxml_dump.xml";
SWTagBXML bxml;
uint32_t mockFopenCalledBefore = IoFunctions::mockFopenCalled;
uint32_t mockFwriteCalledBefore = IoFunctions::mockFwriteCalled;
uint32_t mockFcloseCalledBefore = IoFunctions::mockFcloseCalled;
{
SWTagBXML bxml1;
}
EXPECT_EQ(IoFunctions::mockFopenCalled, mockFopenCalledBefore + 1);
EXPECT_EQ(IoFunctions::mockFwriteCalled, mockFwriteCalledBefore + 1);
EXPECT_EQ(IoFunctions::mockFcloseCalled, mockFcloseCalledBefore + 1);
size_t retSize;
auto data = loadDataFromFile(filename, retSize);
EXPECT_EQ(retSize, bxml.str.size());
EXPECT_EQ(0, strcmp(data.get(), bxml.str.c_str()));
writeDataToFile(filename, "", 1);
VariableBackup<FILE *> backup(&IoFunctions::mockFopenReturned, nullptr);
{
SWTagBXML bxml2;
}
EXPECT_EQ(IoFunctions::mockFopenCalled, mockFopenCalledBefore + 2);
EXPECT_EQ(IoFunctions::mockFwriteCalled, mockFwriteCalledBefore + 1);
EXPECT_EQ(IoFunctions::mockFcloseCalled, mockFcloseCalledBefore + 1);
}