intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2025-12-19 16:24:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

feature: enable bindless mode in ocloc in L0 on dg2

Browse Source 
Before this PR, bindless build option isn't enabled in ocloc by default on dg2.
So aot built program still use bindful kernel.
This PR appends bindless option to ocloc according on releaseHelper config.

Related-To: NEO-7063
Signed-off-by: He, Wenju <wenju.he@intel.com>
This commit is contained in:
He, Wenju
2023-11-24 10:11:49 +00:00
committed by Compute-Runtime-Automation
parent 1a364f5c98
commit c35b13ccae
3 changed files with 33 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
opencl/test/unit_test/offline_compiler/gen12lp/rkl/offline_compiler_tests_rkl.cpp
View File

@@ -27,3 +27,14 @@ RKLTEST_F(MockOfflineCompilerRklTests, givenRklWhenAppendExtraInternalOptionsThe
size_t found = internalOptions.find(NEO::CompilerOptions::forceEmuInt32DivRemSP.data());
EXPECT_NE(std::string::npos, found);
}
RKLTEST_F(MockOfflineCompilerRklTests, givenRklWhenAppendExtraInternalOptionsThenBindlessModeNotApplied) {
MockOfflineCompiler mockOfflineCompiler;
mockOfflineCompiler.deviceName = "rkl";
mockOfflineCompiler.initHardwareInfo(mockOfflineCompiler.deviceName);
std::string internalOptions = mockOfflineCompiler.internalOptions;
mockOfflineCompiler.appendExtraInternalOptions(internalOptions);
size_t found = internalOptions.find(NEO::CompilerOptions::bindlessMode.data());
EXPECT_EQ(std::string::npos, found);
}

20
opencl/test/unit_test/offline_compiler/xe_hpg_core/dg2/offline_compiler_tests_dg2.cpp
View File

@@ -5,6 +5,7 @@
*
*/
#include "shared/source/compiler_interface/compiler_options.h"
#include "shared/source/helpers/constants.h"
#include "shared/source/xe_hpg_core/hw_cmds_dg2.h"
#include "shared/test/common/test_macros/header/per_product_test_definitions.h"
@@ -159,4 +160,21 @@ DG2TEST_F(Dg2OfflineCompilerTests, givenDg2DeprecatedAcronymAndInvalisRevisionId
EXPECT_EQ(mockOfflineCompiler.hwInfo.ipVersion.value, AOT::DG2_G10_A0);
}
} // namespace NEO
DG2TEST_F(Dg2OfflineCompilerTests, givenDg2WhenAppendExtraInternalOptionsThenBindlessModeApplied) {
MockOfflineCompiler mockOfflineCompiler;
mockOfflineCompiler.argHelper->getPrinterRef().setSuppressMessages(true);
std::string deviceStr;
auto deviceID = dg2G10DeviceIds.front();
std::stringstream deviceIDStr, expectedOutput;
mockOfflineCompiler.revisionId = AOT::DG2_G10_A0;
deviceIDStr << "0x" << std::hex << deviceID;
mockOfflineCompiler.initHardwareInfo(deviceIDStr.str());
std::string internalOptions = mockOfflineCompiler.internalOptions;
mockOfflineCompiler.appendExtraInternalOptions(internalOptions);
EXPECT_NE(std::string::npos, internalOptions.find(CompilerOptions::bindlessMode.data()));
}
} // namespace NEO

3
shared/offline_compiler/source/offline_compiler.cpp
View File

@@ -899,6 +899,9 @@ void OfflineCompiler::appendExtraInternalOptions(std::string &internalOptions) {
}
CompilerOptions::concatenateAppend(internalOptions, compilerProductHelper->getCachingPolicyOptions(false));
CompilerOptions::applyExtraInternalOptions(internalOptions, *compilerProductHelper);
if (releaseHelper && !releaseHelper->isBindlessAddressingDisabled()) {
CompilerOptions::concatenateAppend(internalOptions, CompilerOptions::bindlessMode.str());
}
}
void OfflineCompiler::parseDebugSettings() {