intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2025-12-18 22:08:53 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: Set context group count for root device engine correctly

Browse Source 
Related-To: NEO-16676

This ensures that the OsContext is only marked as part of a context group
when useContextGroup is true, aligning the OsContext's state
with the actual context grouping logic.

Signed-off-by: Slawomir Milczarek <slawomir.milczarek@intel.com>
This commit is contained in:
Slawomir Milczarek
2025-12-16 23:51:38 +00:00
committed by Compute-Runtime-Automation
parent ae1721c065
commit c7475fefde
2 changed files with 28 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shared/source/device/root_device.cpp
View File

@@ -107,7 +107,7 @@ bool RootDevice::createRootDeviceEngine(EngineTypeUsage engineTypeUsage, DeviceB
auto osContext = getMemoryManager()->createAndRegisterOsContext(rootCommandStreamReceiver.get(), engineDescriptor);
osContext->setContextGroupCount(gfxCoreHelper.getContextGroupContextsCount());
osContext->setContextGroupCount(useContextGroup ? gfxCoreHelper.getContextGroupContextsCount() : 0);
osContext->setIsPrimaryEngine(isPrimaryEngine);
rootCommandStreamReceiver->setupContext(*osContext);

27
shared/test/unit_test/device/neo_device_tests.cpp
View File

@@ -2977,6 +2977,33 @@ HWTEST_F(DeviceTests, givenMaskedSubDevicesWhenCallingPollForCompletionOnRootDev
EXPECT_EQ(callCount, numMaskedSubDevices);
}
HWTEST_F(DeviceTests, givenEngineUsageWhenCreatingRootDeviceEngineThenIsPartOfContextGroupIsSetCorrectly) {
DebugManagerStateRestore dbgRestorer;
const uint32_t contextGroupSize = 8;
debugManager.flags.ContextGroupSize.set(contextGroupSize);
struct TestCase {
EngineUsage engineUsage;
bool expectedIsPartOfContextGroup;
};
std::vector<TestCase> testCases = {
{EngineUsage::regular, true}, // Regular engine should be part of context group
{EngineUsage::highPriority, false}, // High-priority engine should NOT be part of context group
{EngineUsage::lowPriority, false}, // Low-priority engine should NOT be part of context group
};
for (const auto &testCase : testCases) {
auto device = std::make_unique<MockDevice>();
EngineTypeUsage engineTypeUsage = {aub_stream::ENGINE_CCS, testCase.engineUsage};
bool result = device->createRootDeviceEngine(engineTypeUsage, device->getDeviceBitfield());
EXPECT_TRUE(result);
auto &osContext = device->getAllEngines().back().osContext;
EXPECT_EQ(testCase.expectedIsPartOfContextGroup, osContext->isPartOfContextGroup());
}
}
TEST(DeviceCanAccessPeerTest, givenTheSameDeviceThenCanAccessPeerReturnsTrue) {
UltDeviceFactory deviceFactory{2, 0};
auto rootDevice0 = deviceFactory.rootDevices[0];