intel/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2026-01-07 04:48:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

clang-tidy improvements and code fixes

Browse Source 
Related-To: NEO-562
Change-Id: Iab9d1ed35e64c9fce849e1b0654ec65f731302e8
Signed-off-by: Artur Harasimiuk <artur.harasimiuk@intel.com>
This commit is contained in:
Artur Harasimiuk
2019-11-20 12:23:06 +01:00
committed by sys_ocldev
parent 8ef1466a15
commit cf8283cc9a
11 changed files with 17 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/unit_tests/.clang-tidy
View File

@@ -1,9 +1,9 @@
---
Checks: 'clang-diagnostic-*,clang-analyzer-*,google-default-arguments,modernize-use-override,modernize-use-default-member-init,-clang-analyzer-alpha*,readability-identifier-naming,-clang-analyzer-core.StackAddressEscape,-clang-analyzer-optin.performance.Padding,-clang-analyzer-security.insecureAPI.strcpy,-clang-analyzer-cplusplus.NewDeleteLeaks,-clang-analyzer-core.CallAndMessage,-clang-analyzer-core.uninitialized.Assign,-clang-analyzer-unix.MismatchedDeallocator,-clang-analyzer-core.NonNullParamChecker,-clang-analyzer-core.NullDereference,-clang-analyzer-cplusplus.NewDelete,-clang-analyzer-optin.cplusplus.VirtualCall'
# WarningsAsErrors: '.*'
HeaderFilterRegex: 'runtime/'
HeaderFilterRegex: '/runtime/|/core/|/offline_compiler/|/common/'
AnalyzeTemporaryDtors: false
CheckOptions:
CheckOptions:
- key: google-readability-braces-around-statements.ShortStatementLines
value: '1'
- key: google-readability-function-size.StatementThreshold

2
core/unit_tests/helpers/debug_manager_state_restore.h
View File

@@ -39,7 +39,7 @@ class DebugManagerStateRestore {
class RegistryReaderMock : public SettingsReader {
public:
RegistryReaderMock() {}
~RegistryReaderMock() {}
~RegistryReaderMock() override {}
unsigned int forceRetValue = 1;

6
core/unit_tests/utilities/.clang-tidy
View File

@@ -1,10 +1,9 @@
---
Checks: 'clang-diagnostic-*,clang-analyzer-*,google-default-arguments,modernize-use-override,modernize-use-default-member-init,-clang-analyzer-alpha*,readability-identifier-naming,-clang-analyzer-core.UndefinedBinaryOperatorResult'
# WarningsAsErrors: '.*'
HeaderFilterRegex: 'runtime/'
HeaderFilterRegex: '/runtime/|/core/|/offline_compiler/|/common/'
AnalyzeTemporaryDtors: false
CheckOptions:
CheckOptions:
- key: google-readability-braces-around-statements.ShortStatementLines
value: '1'
- key: google-readability-function-size.StatementThreshold
@@ -30,4 +29,3 @@ CheckOptions:
- key: modernize-use-default-member-init.UseAssignment
value: '1'
...

4
core/unit_tests/utilities/base_object_utils.h
View File

@@ -28,7 +28,7 @@ static ReleaseableObjectPtr<T> clUniquePtr(T *object) {
}
template <class _Ty, class... _Types>
inline ReleaseableObjectPtr<_Ty> make_releaseable(_Types &&... _Args) {
return (ReleaseableObjectPtr<_Ty>(new _Ty(std::forward<_Types>(_Args)...)));
inline ReleaseableObjectPtr<_Ty> make_releaseable(_Types &&... args) {
return (ReleaseableObjectPtr<_Ty>(new _Ty(std::forward<_Types>(args)...)));
}
} // namespace NEO