Commit Graph

9799 Commits

Author SHA1 Message Date
Filip Hazubski
a5ac961726 Do not program thread arbitration policy on command list init and reset
This logic is now redundant and can be removed.

Related-To: NEO-6728

Signed-off-by: Filip Hazubski <filip.hazubski@intel.com>
2022-03-16 12:09:42 +01:00
Maciej Bielski
a71b88fefb PageFaultHandler: speedup UM allocations lookup
Add a per-instance SVMAllocsManager::nonGpuDomainAllocs container for
all allocations to be removed in
moveAllocationsWithinUMAllocsManagerToGpuDomain. This approach replaces
the current iterative search and performs the task faster.

Add 7 new unit-tests to verify the functionality related to
nonGpuDomainAllocs container, both in expected and unexpected/synthetic
scenarios.

For UTs replace a dummy unifiedMemoryManager pointer with a pointer to
an instace of SVMAllocsManager, otherwise a SegFault error is thrown at
the end of tests.

Perform overall cleanup in related tests implementation, includes but
not limited to removal of:

- givenInitialPlacementGpu\
WhenMovingToGpuDomainThenFirstAccessDoesNotInvokeTransfer

As it is fully covered by:

givenAllocationMovedToGpuDomain\
WhenVerifyingPagefaultThenAllocationIsMovedToCpuDomain

- givenInitialPlacementGpu\
WhenVerifyingPagefaultThenFirstAccessDoesNotInvokeTransfer

As it is fully covered by:

givenTbxAndnitialPlacementGpu\
WhenVerifyingPagefaultThenMemoryIsUnprotectedOnly

Finally, reduce code duplication where possible.

Related-To: NEO-6658
Signed-off-by: Maciej Bielski <maciej.bielski@intel.com>
2022-03-16 11:18:24 +01:00
Maciej Bielski
b7f516982b GUIDELINES: add an explicit-this rule
Related-To: NEO-6789
Signed-off-by: Maciej Bielski <maciej.bielski@intel.com>
2022-03-16 11:01:28 +01:00
Filip Hazubski
cd95572443 Reuse common logic of programming SCM fields for gen 9 and gen 11
Logic related to programming non coherent and thread arbitration policy for
gens 9 and 11 has been moved to EncodeComputeMode object, where similar
logic for gens gen12lp and newer is located.

Functions PreambleHelper::programThreadArbitration and
PreambleHelper::getThreadArbitrationCommandsSize have been removed.

Redundant setForceNonCoherent call has been removed from XE HPG

Related-To: NEO-6728

Signed-off-by: Filip Hazubski <filip.hazubski@intel.com>
2022-03-16 10:04:32 +01:00
Aravind Gopalakrishnan
5d90e2ab1d Find copy engines correctly before using in test cases
Signed-off-by: Aravind Gopalakrishnan <aravind.gopalakrishnan@intel.com>
2022-03-15 18:49:14 +01:00
ocldev
8453287f5b igc revision update
Signed-off-by: ocldev <ocldev@intel.com>
2022-03-15 16:09:02 +01:00
Filip Hazubski
32b0f7b014 Remove redundant value CsrSizeRequestFlags::numGrfRequiredChanged
Related-To: NEO-5995

Signed-off-by: Filip Hazubski <filip.hazubski@intel.com>
2022-03-15 15:08:15 +01:00
Daniel Chabrowski
adc5fb30d7 Fix UB with std::optional deref in tests
Accessing optional value with operator-> when it has no value is an UB.

Signed-off-by: Daniel Chabrowski daniel.chabrowski@intel.com
2022-03-15 13:29:59 +01:00
Patryk Wrobel
4cde6ea1ce Detect GPU hangs in CommandMapUnmap::submit()
This change introduces detection of GPU hangs
in CommandMapUnmap::submit() as well as in Event::submitCommand().
ULTs have been added to cover the new code.

Related-To: NEO-6681
Signed-off-by: Patryk Wrobel <patryk.wrobel@intel.com>
2022-03-15 13:17:41 +01:00
Kamil Kopryk
8c4b2aafa1 Move test_hw_info_config.cpp to shared unit tests
Signed-off-by: Kamil Kopryk <kamil.kopryk@intel.com>
Related-To: NEO-6631
2022-03-15 12:36:53 +01:00
Mateusz Jablonski
c7e76ce109 Add support for a new relocation name for implicit args
Related-To: NEO-5081
Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
2022-03-15 12:03:51 +01:00
Artur Harasimiuk
c14dc6d9ed refactor packaging scripts to better utilize ccache
When we build L0 right after OpenCL or vice versa we expect shared code
to be reused from ccache (when enable). Proper setting of project() and
add_subdirectory() helps to achieve this.

Signed-off-by: Artur Harasimiuk <artur.harasimiuk@intel.com>
2022-03-15 10:56:54 +01:00
Kamil Kopryk
a20edd7160 Correct xe_hpc_core files
Signed-off-by: Kamil Kopryk <kamil.kopryk@intel.com>
Related-To: NEO-6631
2022-03-15 09:28:18 +01:00
Artur Harasimiuk
f20c573231 disable prelim headers detection by default
Related-To: NEO-6625
Signed-off-by: Artur Harasimiuk <artur.harasimiuk@intel.com>
2022-03-15 09:14:31 +01:00
Mayank Raghuwanshi
fac75222a3 Move Pci bdf parsing to os specific layer
Related-To: LOCI-2879

Signed-off-by: Mayank Raghuwanshi <mayank.raghuwanshi@intel.com>
2022-03-15 08:58:30 +01:00
Compute-Runtime-Validation
45100d15ff Revert "Correct implicit args relocation name"
This reverts commit b840737b73.

Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
2022-03-14 18:51:49 +01:00
Jaime Arteaga
5038cf6cfc Refactor getMemoryAccessProperties()
Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
2022-03-14 17:15:21 +01:00
Bellekallu Rajkiran
604f2c625e Sysman: Utilize Ioctl helpers for memory module
Memory module translates memory regions without any
runtime query on underlying hardware/kernel. Use
ioctl helpers for memory region translation.

Related-To: LOCI-3006

Signed-off-by: Bellekallu Rajkiran <bellekallu.rajkiran@intel.com>
2022-03-14 16:46:29 +01:00
Daria Hinz
452050ae40 Refactoring the use of PVC device ids
Replacing the old device id implementation
& clearing PVC XT temporary.

Related-To: NEO-6742
Signed-off-by: Daria Hinz <daria.hinz@intel.com>
2022-03-14 15:54:52 +01:00
Filip Hazubski
b79d9a8e10 Correct structs to explicitly initialize members
Affected structs are DebugAreaHeader, Ras and APITracerImp.

Signed-off-by: Filip Hazubski <filip.hazubski@intel.com>
2022-03-14 15:40:28 +01:00
Mateusz Jablonski
bc3cb9768f Stop using DefaultTile4 WA flag
Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
2022-03-14 14:26:38 +01:00
Mateusz Jablonski
b840737b73 Correct implicit args relocation name
Related-To: NEO-5081
Signed-off-by: Mateusz Jablonski <mateusz.jablonski@intel.com>
2022-03-14 14:20:29 +01:00
Lukasz Jobczyk
f8449fb216 Add round robin engine assign controls
Signed-off-by: Lukasz Jobczyk <lukasz.jobczyk@intel.com>
2022-03-14 10:57:20 +01:00
Compute-Runtime-Validation
cee7ded064 Revert "Add setArgBuffer caching to l0"
This reverts commit e6460e5534.

Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
2022-03-13 00:50:42 +01:00
Compute-Runtime-Validation
4f31b569e4 Revert "Correct IMAGE1D_BUFFER width size calculation in BCS"
This reverts commit 3490b489ad.

Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
2022-03-12 20:02:55 +01:00
Spruit, Neil R
c8e60ce3ba Support Circular and chained deps in L0 Dynamic Link
- Added support for Dynamic Module link to allow usage of
symbols that exist thru a circular dependency from the export->import
module & chained dependencies with importModule -> ExportModule ->
ExportModule2.

- Adds a dependency walker which collects all dependent modules whose
export surface state must be made resident for a given kernel
execution to successfully access each function resolved on different
modules.

- Expanded the Dynamic Link Black Box test to allow for testing either
simple linking and circular + chained linkage.

Signed-off-by: Spruit, Neil R <neil.r.spruit@intel.com>
2022-03-11 21:15:08 +01:00
Jaime Arteaga
0e9e0ff5e9 Add ZE_experimental_image extensions to list of supported ones
Signed-off-by: Jaime Arteaga <jaime.a.arteaga.molina@intel.com>
2022-03-11 17:00:14 +01:00
Bartosz Dunajski
058d87f712 Add ForceAllResourcesUncached support to CacheSettingsHelper
Signed-off-by: Bartosz Dunajski <bartosz.dunajski@intel.com>
2022-03-11 15:41:10 +01:00
Daniel Chabrowski
c01f454d42 Test prelim memory manager debug surface
Signed-off-by: Daniel Chabrowski daniel.chabrowski@intel.com
Related-To: NEO-6591
2022-03-11 15:33:44 +01:00
Bartosz Dunajski
c843d152ce Enable prepatcher WA for L0
Signed-off-by: Bartosz Dunajski <bartosz.dunajski@intel.com>
2022-03-11 15:20:32 +01:00
Fabian Zwolinski
2e6d8fefa3 Remove DrmMockImpl class and use DrmMock instead
Related-To: NEO-4914
Signed-off-by: Fabian Zwolinski <fabian.zwolinski@intel.com>
2022-03-11 15:12:11 +01:00
Kamil Kopryk
3ca86e7394 Add whenAubCsrIsCreatedThenCreateHardwareContext hpc aub test
Related-To: NEO-6631


Signed-off-by: Kamil Kopryk <kamil.kopryk@intel.com>
2022-03-11 15:00:57 +01:00
Dominik Dabek
eef82189e5 Improve caching in clSetKernelArgSVMPointer 3/n
Add missing ult for 2/n

Related-To: NEO-6737

Signed-off-by: Dominik Dabek <dominik.dabek@intel.com>
2022-03-11 14:21:14 +01:00
Dominik Dabek
e6460e5534 Add setArgBuffer caching to l0
When trying to set the same values we don't need to set it again.
The pointer and allocId need to be the same.

Related-To: NEO-6737

Signed-off-by: Dominik Dabek <dominik.dabek@intel.com>
2022-03-11 14:20:15 +01:00
Filip Hazubski
3eab7009ac Move SCM related WAs logic from CSR to EncodeComputeMode
This will help with unifying the logic between APIs and GENs.

Related-To: NEO-6728

Signed-off-by: Filip Hazubski <filip.hazubski@intel.com>
2022-03-11 14:00:53 +01:00
Kamil Kopryk
7d6bee26c7 Move pvc helpers to pvc files
Related-To: NEO-6631
Signed-off-by: Kamil Kopryk <kamil.kopryk@intel.com>
2022-03-11 13:46:59 +01:00
Rafal Maziejuk
3490b489ad Correct IMAGE1D_BUFFER width size calculation in BCS
Buffer's default bytesPerPixel value always equals 1 and as
IMAGE1D_BUFFER is originally an image, X coordinate needs to be
multiplied by bytesPerPixel in both copySize and (src/dst)Size.

Signed-off-by: Rafal Maziejuk <rafal.maziejuk@intel.com>
Related-To: NEO-6134
2022-03-11 09:34:40 +01:00
Michal Mrozek
6b29b03c29 Change default thread arbitration policy on PVC.
New default is round robin after stall.
Resolves: NEO-6731

Signed-off-by: Michal Mrozek <michal.mrozek@intel.com>
2022-03-11 09:20:53 +01:00
Joshua Santosh Ranjan
c7ce397b17 Metrics IP Sampling Add Support for Streamer APIs
This Patch adds support for collecting IP Metrics using
StreamerOpen, StreamerClose and StreamerReadData

Related-To: LOCI-2755
Related-To: LOCI-2756

Signed-off-by: Joshua Santosh Ranjan <joshua.santosh.ranjan@intel.com>
2022-03-11 03:03:22 +01:00
Brandon Yates
16b0ebe372 Update manifest to L0 loader 1.7.15
Signed-off-by: Brandon Yates <brandon.yates@intel.com>
2022-03-11 02:20:53 +01:00
Grzegorz Choinski
5183de21fa fix finding metrics when found empty
Do not try to include empty directories, as cmake will not
explicitely return directiories, which would be searched
by compiler anyway. Such found should still be considered
as successful.

Signed-off-by: Grzegorz Choinski <grzegorz.choinski@intel.com>
2022-03-10 23:32:33 +01:00
Bartosz Dunajski
c6e27bdc18 Enable prepatcher DirectSubmission WA
Signed-off-by: Bartosz Dunajski <bartosz.dunajski@intel.com>
2022-03-10 20:23:11 +01:00
Bartosz Dunajski
79fedd59e4 Add BB_START prepatching WA - disabled by default
Signed-off-by: Bartosz Dunajski <bartosz.dunajski@intel.com>
2022-03-10 17:05:53 +01:00
Krystian Chmielewski
1b4319fdab Update zebin note target metadata
This commit removes ZebinTargetMetadata struct, and uses
ZebinTargetFlags for both target validations: via machine type, and
via intel gt notes.

Signed-off-by: Krystian Chmielewski <krystian.chmielewski@intel.com>
2022-03-10 16:47:01 +01:00
Bartosz Dunajski
b8028d79c7 PVC: Fix compute units for scratch calculation
Signed-off-by: Bartosz Dunajski <bartosz.dunajski@intel.com>
2022-03-10 14:04:58 +01:00
Lukasz Jobczyk
c8ba97e492 Restore gpgpu csr's mutex lock in the enqueue blit
Signed-off-by: Lukasz Jobczyk <lukasz.jobczyk@intel.com>
2022-03-10 13:36:46 +01:00
Bartosz Dunajski
b8d5fac10f Add missing lock in MapOperationsHandler
Signed-off-by: Bartosz Dunajski <bartosz.dunajski@intel.com>
2022-03-10 13:17:46 +01:00
Bartosz Dunajski
e24322f266 Debug flag to control MI_ARB_CHECK prefetcher
Signed-off-by: Bartosz Dunajski <bartosz.dunajski@intel.com>
2022-03-10 12:50:05 +01:00
Compute-Runtime-Validation
41c51df086 Revert "Recycle old command buffers of immediate command lists"
This reverts commit 8f93f4f3ec.

Signed-off-by: Compute-Runtime-Validation <compute-runtime-validation@intel.com>
2022-03-10 09:12:47 +01:00
ocldev
fe53879f16 dependencies update
Signed-off-by: ocldev <ocldev@intel.com>
2022-03-09 22:20:33 +01:00