intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-27 06:06:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Flang][OpenMP] Mark mergeable and untied clauses as unsupported (#71209)

Browse Source 
These two clauses are not supported in the OpenMP Dialect to LLVM
conversion. Mark as TODO till support is added.
This commit is contained in:
Kiran Chandramohan
2023-11-06 15:01:57 +00:00
committed by GitHub
parent 1a1a5ec756
commit 12756831e4
5 changed files with 30 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
flang/lib/Lower/OpenMP.cpp
View File

@@ -3092,8 +3092,6 @@ genOMP(Fortran::lower::AbstractConverter &converter,
!std::get_if<Fortran::parser::OmpClause::Allocate>(&clause.u) &&
!std::get_if<Fortran::parser::OmpClause::Default>(&clause.u) &&
!std::get_if<Fortran::parser::OmpClause::Final>(&clause.u) &&
!std::get_if<Fortran::parser::OmpClause::Untied>(&clause.u) &&
!std::get_if<Fortran::parser::OmpClause::Mergeable>(&clause.u) &&
!std::get_if<Fortran::parser::OmpClause::Priority>(&clause.u) &&
!std::get_if<Fortran::parser::OmpClause::Reduction>(&clause.u) &&
!std::get_if<Fortran::parser::OmpClause::Depend>(&clause.u) &&

32
flang/test/Lower/OpenMP/FIR/task.f90
View File

@@ -40,34 +40,6 @@ subroutine omp_task_final(bar)
!$omp end task
end subroutine omp_task_final
!===============================================================================
! `untied` clause
!===============================================================================
!CHECK-LABEL: func @_QPomp_task_untied() {
subroutine omp_task_untied()
!CHECK: omp.task untied {
!$omp task untied
!CHECK: fir.call @_QPfoo() {{.*}}: () -> ()
call foo()
!CHECK: omp.terminator
!$omp end task
end subroutine omp_task_untied
!===============================================================================
! `mergeable` clause
!===============================================================================
!CHECK-LABEL: func @_QPomp_task_mergeable() {
subroutine omp_task_mergeable()
!CHECK: omp.task mergeable {
!$omp task mergeable
!CHECK: fir.call @_QPfoo() {{.*}}: () -> ()
call foo()
!CHECK: omp.terminator
!$omp end task
end subroutine omp_task_mergeable
!===============================================================================
! `priority` clause
!===============================================================================
@@ -245,8 +217,8 @@ subroutine task_multiple_clauses()
integer :: x, y, z
logical :: buzz
!CHECK: omp.task if(%{{.+}}) final(%{{.+}}) untied mergeable priority(%{{.+}}) allocate(%{{.+}} : i32 -> %{{.+}} : !fir.ref<i32>) {
!$omp task if(buzz) final(buzz) untied mergeable priority(z) allocate(omp_high_bw_mem_alloc: x) private(x) firstprivate(y)
!CHECK: omp.task if(%{{.+}}) final(%{{.+}}) priority(%{{.+}}) allocate(%{{.+}} : i32 -> %{{.+}} : !fir.ref<i32>) {
!$omp task if(buzz) final(buzz) priority(z) allocate(omp_high_bw_mem_alloc: x) private(x) firstprivate(y)
!CHECK: %[[x_priv:.+]] = fir.alloca i32
!CHECK: %[[y_priv:.+]] = fir.alloca i32

13
flang/test/Lower/OpenMP/Todo/task_mergeable.f90 Normal file
View File

@@ -0,0 +1,13 @@
! RUN: %not_todo_cmd bbc -emit-fir -fopenmp -o - %s 2>&1 | FileCheck %s
! RUN: %not_todo_cmd %flang_fc1 -emit-fir -fopenmp -o - %s 2>&1 | FileCheck %s
!===============================================================================
! `mergeable` clause
!===============================================================================
! CHECK: not yet implemented: OpenMP Block construct clause
subroutine omp_task_mergeable()
!$omp task mergeable
call foo()
!$omp end task
end subroutine omp_task_mergeable

13
flang/test/Lower/OpenMP/Todo/task_untied.f90 Normal file
View File

@@ -0,0 +1,13 @@
! RUN: %not_todo_cmd bbc -emit-fir -fopenmp -o - %s 2>&1 | FileCheck %s
! RUN: %not_todo_cmd %flang_fc1 -emit-fir -fopenmp -o - %s 2>&1 | FileCheck %s
!===============================================================================
! `untied` clause
!===============================================================================
! CHECK: not yet implemented: OpenMP Block construct clause
subroutine omp_task_untied()
!$omp task untied
call foo()
!$omp end task
end subroutine omp_task_untied

32
flang/test/Lower/OpenMP/task.f90
View File

@@ -40,34 +40,6 @@ subroutine omp_task_final(bar)
!$omp end task
end subroutine omp_task_final
!===============================================================================
! `untied` clause
!===============================================================================
!CHECK-LABEL: func @_QPomp_task_untied() {
subroutine omp_task_untied()
!CHECK: omp.task untied {
!$omp task untied
!CHECK: fir.call @_QPfoo() {{.*}}: () -> ()
call foo()
!CHECK: omp.terminator
!$omp end task
end subroutine omp_task_untied
!===============================================================================
! `mergeable` clause
!===============================================================================
!CHECK-LABEL: func @_QPomp_task_mergeable() {
subroutine omp_task_mergeable()
!CHECK: omp.task mergeable {
!$omp task mergeable
!CHECK: fir.call @_QPfoo() {{.*}}: () -> ()
call foo()
!CHECK: omp.terminator
!$omp end task
end subroutine omp_task_mergeable
!===============================================================================
! `priority` clause
!===============================================================================
@@ -253,8 +225,8 @@ subroutine task_multiple_clauses()
integer :: x, y, z
logical :: buzz
!CHECK: omp.task if(%{{.+}}) final(%{{.+}}) untied mergeable priority(%{{.+}}) allocate(%{{.+}} : i32 -> %{{.+}} : !fir.ref<i32>) {
!$omp task if(buzz) final(buzz) untied mergeable priority(z) allocate(omp_high_bw_mem_alloc: x) private(x) firstprivate(y)
!CHECK: omp.task if(%{{.+}}) final(%{{.+}}) priority(%{{.+}}) allocate(%{{.+}} : i32 -> %{{.+}} : !fir.ref<i32>) {
!$omp task if(buzz) final(buzz) priority(z) allocate(omp_high_bw_mem_alloc: x) private(x) firstprivate(y)
!CHECK: %[[X_PRIV_ALLOCA:.+]] = fir.alloca i32 {bindc_name = "x", pinned, uniq_name = "_QFtask_multiple_clausesEx"}
!CHECK: %[[X_PRIV:.+]]:2 = hlfir.declare %[[X_PRIV_ALLOCA]] {uniq_name = "_QFtask_multiple_clausesEx"} : (!fir.ref<i32>) -> (!fir.ref<i32>, !fir.ref<i32>)