intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-17 06:40:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

[lldb] Use heterogenous lookups with std::map (NFC) (#115590) (#115634)

Browse Source 
Heterogenous lookups allow us to call find with StringRef, avoiding a
temporary heap allocation of std::string.
This commit is contained in:
Kazu Hirata
2024-11-10 07:50:24 -08:00
committed by GitHub
parent 1e25c921d5
commit 15ce2e183f
2 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lldb/include/lldb/Interpreter/CommandObject.h
View File

@@ -35,8 +35,9 @@ namespace lldb_private {
template <typename ValueType>
int AddNamesMatchingPartialString(
const std::map<std::string, ValueType> &in_map, llvm::StringRef cmd_str,
StringList &matches, StringList *descriptions = nullptr) {
const std::map<std::string, ValueType, std::less<>> &in_map,
llvm::StringRef cmd_str, StringList &matches,
StringList *descriptions = nullptr) {
int number_added = 0;
const bool add_all = cmd_str.empty();
@@ -54,7 +55,8 @@ int AddNamesMatchingPartialString(
}
template <typename ValueType>
size_t FindLongestCommandWord(std::map<std::string, ValueType> &dict) {
size_t
FindLongestCommandWord(std::map<std::string, ValueType, std::less<>> &dict) {
auto end = dict.end();
size_t max_len = 0;
@@ -107,7 +109,7 @@ public:
typedef std::vector<CommandArgumentData>
CommandArgumentEntry; // Used to build individual command argument lists
typedef std::map<std::string, lldb::CommandObjectSP> CommandMap;
typedef std::map<std::string, lldb::CommandObjectSP, std::less<>> CommandMap;
CommandObject(CommandInterpreter &interpreter, llvm::StringRef name,
llvm::StringRef help = "", llvm::StringRef syntax = "",

4
lldb/source/Commands/CommandObjectMultiword.cpp
View File

@@ -32,7 +32,7 @@ CommandObjectMultiword::GetSubcommandSPExact(llvm::StringRef sub_cmd) {
if (m_subcommand_dict.empty())
return {};
auto pos = m_subcommand_dict.find(std::string(sub_cmd));
auto pos = m_subcommand_dict.find(sub_cmd);
if (pos == m_subcommand_dict.end())
return {};
@@ -64,7 +64,7 @@ CommandObjectSP CommandObjectMultiword::GetSubcommandSP(llvm::StringRef sub_cmd,
// function, since I now know I have an exact match...
sub_cmd = matches->GetStringAtIndex(0);
pos = m_subcommand_dict.find(std::string(sub_cmd));
pos = m_subcommand_dict.find(sub_cmd);
if (pos != m_subcommand_dict.end())
return_cmd_sp = pos->second;
}