intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-20 10:58:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

[CodeGen] Fix a regression by emitting lambda expressions in EmitLValue

Browse Source 
This ability was removed in r351487, but it's needed when a lambda appears as an
OpaqueValueExpr subexpression of a PseudoObjectExpr.

rdar://49030379

Differential revision: https://reviews.llvm.org/D60099

llvm-svn: 357515
This commit is contained in:
Erik Pilkington
2019-04-02 19:48:07 +00:00
parent 0fd3c68c1a
commit 3299ead8e9
2 changed files with 49 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
clang/lib/CodeGen/CGExpr.cpp
View File

@@ -1294,6 +1294,8 @@ LValue CodeGenFunction::EmitLValue(const Expr *E) {
return EmitCXXBindTemporaryLValue(cast<CXXBindTemporaryExpr>(E));
case Expr::CXXUuidofExprClass:
return EmitCXXUuidofLValue(cast<CXXUuidofExpr>(E));
case Expr::LambdaExprClass:
return EmitAggExprToLValue(E);
case Expr::ExprWithCleanupsClass: {
const auto *cleanups = cast<ExprWithCleanups>(E);

47
clang/test/CodeGenObjCXX/property-lvalue-lambda.mm Normal file
View File

@@ -0,0 +1,47 @@
// RUN: %clang_cc1 -fblocks -disable-llvm-passes -triple x86_64-apple-darwin10 -std=c++17 -emit-llvm -o - %s | FileCheck %s
typedef void (^blk_t)();
typedef void (*fnptr_t)();
@interface X
@property blk_t blk;
@property fnptr_t fnptr;
@end
template <class T>
blk_t operator+(blk_t lhs, T) { return lhs; }
template <class T>
fnptr_t operator+(fnptr_t lhs, T) { return lhs; }
// CHECK-LABEL: define void @_Z2t1P1X
void t1(X *x) {
// Check that we call lambda.operator blk_t(), and that we send that result to
// the setter.
// CHECK: [[CALL:%.*]] = call void ()* @"_ZZ2t1P1XENK3$_0cvU13block_pointerFvvEEv"
// CHECK: call void{{.*}}@objc_msgSend{{.*}}({{.*}} void ()* [[CALL]])
x.blk = [] {};
// CHECK: [[CALL2:%.*]] = call void ()* @"_ZZ2t1P1XENK3$_1cvPFvvEEv"
// CHECK: call void{{.*}}@objc_msgSend{{.*}}({{.*}} void ()* [[CALL2]])
x.fnptr = [] {};
}
// CHECK-LABEL: define void @_Z2t2P1X
void t2(X *x) {
// Test the case when the lambda isn't unique. (see OpaqueValueExpr::isUnique)
// FIXME: This asserts if the lambda isn't trivially copy/movable.
// [x setBlk: operator+([x blk], [] {})]
// CHECK: call void{{.*}}@objc_msgSend{{.*}}
// CHECK: [[PLUS:%.*]] = call void ()* @"_ZplIZ2t2P1XE3$_2EU13block_pointerFvvES4_T_"
// CHECK: call void{{.*}}@objc_msgSend{{.*}}({{.*}} [[PLUS]])
x.blk += [] {};
// CHECK: call void{{.*}}@objc_msgSend{{.*}}
// CHECK: [[PLUS:%.*]] = call void ()* @"_ZplIZ2t2P1XE3$_3EPFvvES4_T_"
// CHECK: call void{{.*}}@objc_msgSend{{.*}}({{.*}} [[PLUS]])
x.fnptr += [] {};
}