intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-02-02 02:00:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

[LLD] Set alignment as part of Characteristics in TLS table.

Browse Source 
Fixes https://bugs.llvm.org/show_bug.cgi?id=46473

LLD wasn't previously specifying any specific alignment in the TLS table's Characteristics field so the loader would just assume the default value (16 bytes). This works most of the time except if you have thread locals that want specific higher alignments (e.g. 32 as in the bug) *even* if they specify an alignment on the thread local. This change updates LLD to take the max alignment from tls section.

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D88637
This commit is contained in:
Luqman Aden
2020-10-14 19:39:08 -07:00
parent 7fe13af676
commit 32a4ad3b6c
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lld/COFF/Writer.cpp
View File

@@ -2067,7 +2067,7 @@ void Writer::fixTlsAlignment() {
: sizeof(object::coff_tls_directory32);
if (tlsOffset + directorySize > sec->getRawSize())
fatal("_tls_used is malformed");
fatal("_tls_used sym is malformed");
if (config->is64()) {
object::coff_tls_directory64 *tlsDir =