intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-13 11:02:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

[lldb][NFC] Remove dead code that is supposed to handle invalid command options

Browse Source 
Summary:
We currently have a bunch of code that is supposed to handle invalid command options, but
all this code is unreachable because invalid options are already handled in `Options::Parse`.
The only way we can reach this code is when we declare but then not implement an option
(which will be made impossible with D65386, which is also when we can completely remove
the `default` cases).

This patch replaces all this code with `llvm_unreachable` to make clear this is dead code
that can't be reached.

Reviewers: JDevlieghere

Reviewed By: JDevlieghere

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D66522

llvm-svn: 369625
This commit is contained in:
Raphael Isemann
2019-08-22 08:08:05 +00:00
parent ae34ed2c0d
commit 36162014c4
27 changed files with 82 additions and 217 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
lldb/source/Commands/CommandObjectBreakpoint.cpp
View File

@@ -141,9 +141,7 @@ public:
}
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -206,9 +204,7 @@ public:
m_use_dummy = true;
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -486,9 +482,7 @@ public:
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -1208,9 +1202,7 @@ public:
m_internal = true;
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -1342,9 +1334,7 @@ public:
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -1496,9 +1486,7 @@ public:
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -1643,9 +1631,7 @@ public:
break;
default:
error.SetErrorStringWithFormat("unrecognized short option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
}
@@ -1713,7 +1699,8 @@ public:
"invalid boolean value '%s' passed for -L option",
option_arg.str().c_str());
} break;
default:
llvm_unreachable("Unimplemented option");
}
return error;
@@ -2175,9 +2162,7 @@ public:
break;
}
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -2293,9 +2278,7 @@ public:
m_append = true;
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;

6
lldb/source/Commands/CommandObjectBreakpointCommand.cpp
View File

@@ -324,7 +324,7 @@ are no syntax errors may indicate that a function was declared but never called.
break;
default:
break;
llvm_unreachable("Unimplemented option");
}
return error;
}
@@ -516,9 +516,7 @@ public:
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;

24
lldb/source/Commands/CommandObjectCommands.cpp
View File

@@ -85,9 +85,7 @@ protected:
m_clear.SetOptionWasSet();
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -253,9 +251,7 @@ protected:
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -370,9 +366,7 @@ protected:
break;
default:
error.SetErrorStringWithFormat("invalid short option character '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -1161,9 +1155,7 @@ private:
m_syntax.assign(option_arg);
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -1414,9 +1406,7 @@ protected:
m_allow_reload = true;
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -1568,9 +1558,7 @@ protected:
option_arg.str().c_str());
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;

4
lldb/source/Commands/CommandObjectDisassemble.cpp
View File

@@ -147,9 +147,7 @@ Status CommandObjectDisassemble::CommandOptions::SetOptionValue(
} break;
default:
error.SetErrorStringWithFormat("unrecognized short option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;

4
lldb/source/Commands/CommandObjectExpression.cpp
View File

@@ -166,9 +166,7 @@ Status CommandObjectExpression::CommandOptions::SetOptionValue(
}
default:
error.SetErrorStringWithFormat("invalid short option character '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;

12
lldb/source/Commands/CommandObjectFrame.cpp
View File

@@ -92,9 +92,7 @@ public:
} break;
default:
error.SetErrorStringWithFormat("invalid short option character '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -257,9 +255,7 @@ public:
break;
default:
error.SetErrorStringWithFormat("invalid short option character '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -763,9 +759,7 @@ private:
m_regex = true;
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;

4
lldb/source/Commands/CommandObjectHelp.h
View File

@@ -52,9 +52,7 @@ public:
m_show_hidden = true;
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;

4
lldb/source/Commands/CommandObjectLog.cpp
View File

@@ -113,9 +113,7 @@ public:
log_options |= LLDB_LOG_OPTION_PREPEND_FILE_FUNCTION;
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;

12
lldb/source/Commands/CommandObjectMemory.cpp
View File

@@ -96,9 +96,7 @@ public:
break;
default:
error.SetErrorStringWithFormat("unrecognized short option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
}
@@ -936,9 +934,7 @@ public:
break;
default:
error.SetErrorStringWithFormat("unrecognized short option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
}
@@ -1226,9 +1222,7 @@ public:
} break;
default:
error.SetErrorStringWithFormat("unrecognized short option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
}

23
lldb/source/Commands/CommandObjectPlatform.cpp
View File

@@ -117,8 +117,7 @@ public:
m_permissions |= lldb::eFilePermissionsWorldExecute;
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'", short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -632,9 +631,7 @@ protected:
option_arg.str().c_str());
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -718,9 +715,7 @@ protected:
m_data.assign(option_arg);
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -1270,9 +1265,7 @@ protected:
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -1426,9 +1419,7 @@ public:
break;
default:
error.SetErrorStringWithFormat("invalid short option character '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
}
@@ -1587,9 +1578,7 @@ public:
timeout = std::chrono::seconds(timeout_sec);
break;
default:
error.SetErrorStringWithFormat("invalid short option character '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;

24
lldb/source/Commands/CommandObjectProcess.cpp
View File

@@ -307,9 +307,7 @@ public:
break;
default:
error.SetErrorStringWithFormat("invalid short option character '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
}
@@ -538,9 +536,7 @@ protected:
break;
default:
error.SetErrorStringWithFormat("invalid short option character '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
}
@@ -688,9 +684,7 @@ public:
}
break;
default:
error.SetErrorStringWithFormat("invalid short option character '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
}
@@ -775,9 +769,7 @@ public:
break;
default:
error.SetErrorStringWithFormat("invalid short option character '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
}
@@ -896,9 +888,7 @@ public:
install_path.SetFile(option_arg, FileSpec::Style::native);
break;
default:
error.SetErrorStringWithFormat("invalid short option character '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
}
@@ -1277,9 +1267,7 @@ public:
pass = option_arg;
break;
default:
error.SetErrorStringWithFormat("invalid short option character '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
}

4
lldb/source/Commands/CommandObjectRegister.cpp
View File

@@ -272,9 +272,7 @@ protected:
break;
default:
error.SetErrorStringWithFormat("unrecognized short option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
}

12
lldb/source/Commands/CommandObjectSettings.cpp
View File

@@ -104,9 +104,7 @@ insert-before or insert-after.");
m_global = true;
break;
default:
error.SetErrorStringWithFormat("unrecognized options '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -355,9 +353,7 @@ public:
m_append = true;
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -456,9 +452,7 @@ public:
m_filename.assign(option_arg);
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;

8
lldb/source/Commands/CommandObjectSource.cpp
View File

@@ -82,9 +82,7 @@ class CommandObjectSourceInfo : public CommandObjectParsed {
modules.push_back(std::string(option_arg));
break;
default:
error.SetErrorStringWithFormat("unrecognized short option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -683,9 +681,7 @@ class CommandObjectSourceList : public CommandObjectParsed {
reverse = true;
break;
default:
error.SetErrorStringWithFormat("unrecognized short option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;

12
lldb/source/Commands/CommandObjectTarget.cpp
View File

@@ -2010,9 +2010,7 @@ public:
break;
default:
error.SetErrorStringWithFormat("invalid short option character '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
}
@@ -3356,8 +3354,7 @@ public:
break;
default:
error.SetErrorStringWithFormat("unrecognized option %c.", short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -3706,6 +3703,8 @@ public:
case 'r':
m_use_regex = true;
break;
default:
llvm_unreachable("Unimplemented option");
}
return error;
@@ -4573,8 +4572,7 @@ public:
break;
default:
error.SetErrorStringWithFormat("unrecognized option %c.", short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
}

24
lldb/source/Commands/CommandObjectThread.cpp
View File

@@ -281,9 +281,7 @@ public:
"invalid boolean value for option '%c'", short_option);
} break;
default:
error.SetErrorStringWithFormat("invalid short option character '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
}
@@ -485,9 +483,7 @@ public:
break;
default:
error.SetErrorStringWithFormat("invalid short option character '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
}
@@ -1037,9 +1033,7 @@ public:
}
} break;
default:
error.SetErrorStringWithFormat("invalid short option character '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
}
@@ -1426,7 +1420,7 @@ public:
break;
default:
return Status("invalid short option character '%c'", short_option);
llvm_unreachable("Unimplemented option");
}
return error;
}
@@ -1560,9 +1554,7 @@ public:
}
} break;
default:
error.SetErrorStringWithFormat("invalid short option character '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
}
@@ -1744,7 +1736,7 @@ public:
m_force = true;
break;
default:
return Status("invalid short option character '%c'", short_option);
llvm_unreachable("Unimplemented option");
}
return error;
}
@@ -1866,9 +1858,7 @@ public:
m_verbose = true;
break;
default:
error.SetErrorStringWithFormat("invalid short option character '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
}

43
lldb/source/Commands/CommandObjectType.cpp
View File

@@ -323,9 +323,7 @@ private:
m_regex = true;
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -548,9 +546,7 @@ private:
m_custom_type_name.assign(option_value);
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -736,9 +732,7 @@ protected:
m_language = Language::GetLanguageTypeFromString(option_arg);
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -867,9 +861,7 @@ private:
m_delete_all = true;
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -987,9 +979,7 @@ class CommandObjectTypeFormatterList : public CommandObjectParsed {
m_category_language.SetOptionWasSet();
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -1240,8 +1230,7 @@ Status CommandObjectTypeSummaryAdd::CommandOptions::SetOptionValue(
m_flags.SetHideItemNames(true);
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'", short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -1739,9 +1728,7 @@ class CommandObjectTypeCategoryDefine : public CommandObjectParsed {
error = m_cate_language.SetValueFromString(option_arg);
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -1839,9 +1826,7 @@ class CommandObjectTypeCategoryEnable : public CommandObjectParsed {
}
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -2008,9 +1993,7 @@ class CommandObjectTypeCategoryDisable : public CommandObjectParsed {
}
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -2432,9 +2415,7 @@ private:
m_regex = true;
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -2687,9 +2668,7 @@ protected:
break;
default:
error.SetErrorStringWithFormat("invalid short option character '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;

12
lldb/source/Commands/CommandObjectWatchpoint.cpp
View File

@@ -196,9 +196,7 @@ public:
m_level = lldb::eDescriptionLevelVerbose;
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -545,9 +543,7 @@ public:
option_arg.str().c_str());
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
@@ -666,9 +662,7 @@ public:
m_condition_passed = true;
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;

2
lldb/source/Commands/CommandObjectWatchpointCommand.cpp
View File

@@ -354,7 +354,7 @@ are no syntax errors may indicate that a function was declared but never called.
break;
default:
break;
llvm_unreachable("Unimplemented option");
}
return error;
}

3
lldb/source/Interpreter/OptionGroupArchitecture.cpp
View File

@@ -46,8 +46,7 @@ OptionGroupArchitecture::SetOptionValue(uint32_t option_idx,
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'", short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;

3
lldb/source/Interpreter/OptionGroupFormat.cpp
View File

@@ -160,8 +160,7 @@ Status OptionGroupFormat::SetOptionValue(uint32_t option_idx,
} break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'", short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;

3
lldb/source/Interpreter/OptionGroupOutputFile.cpp
View File

@@ -50,8 +50,7 @@ OptionGroupOutputFile::SetOptionValue(uint32_t option_idx,
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'", short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;

3
lldb/source/Interpreter/OptionGroupPlatform.cpp
View File

@@ -113,8 +113,7 @@ OptionGroupPlatform::SetOptionValue(uint32_t option_idx,
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'", short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;
}

3
lldb/source/Interpreter/OptionGroupUUID.cpp
View File

@@ -40,8 +40,7 @@ Status OptionGroupUUID::SetOptionValue(uint32_t option_idx,
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'", short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;

3
lldb/source/Interpreter/OptionGroupValueObjectDisplay.cpp
View File

@@ -152,8 +152,7 @@ Status OptionGroupValueObjectDisplay::SetOptionValue(
break;
default:
error.SetErrorStringWithFormat("unrecognized option '%c'", short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;

4
lldb/source/Interpreter/OptionGroupVariable.cpp
View File

@@ -109,9 +109,7 @@ OptionGroupVariable::SetOptionValue(uint32_t option_idx,
error = summary_string.SetCurrentValue(option_arg);
break;
default:
error.SetErrorStringWithFormat("unrecognized short option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;

4
lldb/source/Interpreter/OptionGroupWatchpoint.cpp
View File

@@ -101,9 +101,7 @@ OptionGroupWatchpoint::SetOptionValue(uint32_t option_idx,
break;
default:
error.SetErrorStringWithFormat("unrecognized short option '%c'",
short_option);
break;
llvm_unreachable("Unimplemented option");
}
return error;