intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-21 12:19:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

[libc] Fix strftime_test (#165770)

Browse Source 
A typo in #165711 caused sanitizer failures (the small buffer was used
for the larger test). Renamed the variables to avoid the mistake in
future.
This commit is contained in:
Michael Jones
2025-10-30 12:36:51 -07:00
committed by GitHub
parent 291b8ce40d
commit 39189c3e99
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
libc/test/src/time/strftime_test.cpp
View File

@@ -2329,20 +2329,21 @@ TEST(LlvmLibcStrftimeTest, TimeFormatFullDateTime) {
TEST(LlvmLibcStrftimeTest, BufferTooSmall) {
struct tm time;
char buffer[1];
char tiny_buffer[1];
time.tm_year = get_adjusted_year(2025);
time.tm_mon = 10;
time.tm_mday = 24;
size_t written =
LIBC_NAMESPACE::strftime(buffer, sizeof(buffer), "%F", &time);
LIBC_NAMESPACE::strftime(tiny_buffer, sizeof(tiny_buffer), "%F", &time);
EXPECT_EQ(written, size_t{0});
char buffer2[10];
char small_buffer[10];
// The string "2025-11-24" is 10 chars,
// so strftime needs 10 + 1 bytes to write the string and the null terminator.
written = LIBC_NAMESPACE::strftime(buffer, sizeof(buffer2), "%F", &time);
written =
LIBC_NAMESPACE::strftime(small_buffer, sizeof(small_buffer), "%F", &time);
EXPECT_EQ(written, size_t{0});
}