intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-14 03:50:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

[clang-doc] simplify filename selection for namespaces (#162885)

Browse Source 
determineFileName was confusing regarding namespaces. The comment and
conditional were both misleading. Now, we just check against a static
global namespace USR to make a file use "index", or just use the name.
This commit is contained in:
Erick Velez
2025-10-10 13:34:11 -07:00
committed by GitHub
parent 9f0f6e8dda
commit 3af43e303c
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
clang-tools-extra/clang-doc/JSONGenerator.cpp
View File

@@ -582,11 +582,10 @@ static SmallString<16> determineFileName(Info *I, SmallString<128> &Path) {
if (I->IT == InfoType::IT_record) {
auto *RecordSymbolInfo = static_cast<SymbolInfo *>(I);
FileName = RecordSymbolInfo->MangledName;
} else if (I->IT == InfoType::IT_namespace && I->Name != "")
// Serialize the global namespace as index.json
FileName = I->Name;
} else if (I->USR == GlobalNamespaceID)
FileName = "index";
else
FileName = I->getFileBaseName();
FileName = I->Name;
sys::path::append(Path, FileName + ".json");
return FileName;
}

3
clang-tools-extra/clang-doc/Representation.h
View File

@@ -30,6 +30,9 @@ namespace doc {
// SHA1'd hash of a USR.
using SymbolID = std::array<uint8_t, 20>;
constexpr SymbolID GlobalNamespaceID = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0};
struct BaseRecordInfo;
struct EnumInfo;
struct FunctionInfo;