intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-13 11:02:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

[lldb] Print an error for unsupported combinations of log options

Browse Source 
Print an error for unsupported combinations of log handlers and log
options. Only the stream log handler takes a file and only the circular
and stream handler take a buffer size. This cannot be dealt with through
option groups because the option combinations depend on the requested
handler.

Differential revision: https://reviews.llvm.org/D143623
This commit is contained in:
Jonas Devlieghere
2023-02-09 09:04:44 -08:00
parent 08b1708084
commit 3c565c2466
2 changed files with 19 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lldb/source/Commands/CommandObjectLog.cpp
View File

@@ -177,6 +177,20 @@ protected:
return false;
}
if ((m_options.handler != eLogHandlerCircular &&
m_options.handler != eLogHandlerStream) &&
m_options.buffer_size.GetCurrentValue() != 0) {
result.AppendError("a buffer size can only be specified for the circular "
"and stream buffer handler.\n");
return false;
}
if (m_options.handler != eLogHandlerStream && m_options.log_file) {
result.AppendError(
"a file name can only be specified for the stream handler.\n");
return false;
}
// Store into a std::string since we're about to shift the channel off.
const std::string channel = std::string(args[0].ref());
args.Shift(); // Shift off the channel

5
lldb/test/Shell/Log/TestHandlers.test Normal file
View File

@@ -0,0 +1,5 @@
# RUN: %lldb -o 'log enable --log-handler os --file /tmp/foo gdb-remote packets' 2>&1 | FileCheck %s --check-prefix UNSUPPORTED-FILE
# RUN: %lldb -o 'log enable --log-handler os --buffer 10 gdb-remote packets' 2>&1 | FileCheck %s --check-prefix UNSUPPORTED-BUFFER
# UNSUPPORTED-FILE: a file name can only be specified for the stream handler
# UNSUPPORTED-BUFFER: a buffer size can only be specified for the circular and stream buffer handler