intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-20 10:58:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

[ADT] Use "constexpr if" in get_hashable_data (NFC) (#157309)

Browse Source 
This patch combines two implementations of get_hashable_data into one
with "constexpr if".  I'm retaining the original return type of the
second variant, size_t, with static_cast<size_t>.  Moving away from
template metaprogramming should improve readability.
This commit is contained in:
Kazu Hirata
2025-09-07 10:39:23 -07:00
committed by GitHub
parent b50ad945dd
commit 456e49e805
1 changed files with 10 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
llvm/include/llvm/ADT/Hashing.h
View File

@@ -349,20 +349,16 @@ template <typename T, typename U> struct is_hashable_data<std::pair<T, U> >
sizeof(std::pair<T, U>))> {};
/// Helper to get the hashable data representation for a type.
/// This variant is enabled when the type itself can be used.
template <typename T>
std::enable_if_t<is_hashable_data<T>::value, T>
get_hashable_data(const T &value) {
return value;
}
/// Helper to get the hashable data representation for a type.
/// This variant is enabled when we must first call hash_value and use the
/// result as our data.
template <typename T>
std::enable_if_t<!is_hashable_data<T>::value, size_t>
get_hashable_data(const T &value) {
using ::llvm::hash_value;
return hash_value(value);
template <typename T> auto get_hashable_data(const T &value) {
if constexpr (is_hashable_data<T>::value) {
// This variant is enabled when the type itself can be used.
return value;
} else {
// This variant is enabled when we must first call hash_value and use the
// result as our data.
using ::llvm::hash_value;
return static_cast<size_t>(hash_value(value));
}
}
/// Helper to store data from a value into a buffer and advance the