intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-02-05 04:46:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

Driver: Remove some superfluous calls to Arg->claim()

Browse Source 
Args.getLastArg() claims the Arg it returns, so calling claim on these
results is unnecessary.

llvm-svn: 211403
This commit is contained in:
Justin Bogner
2014-06-20 21:12:53 +00:00
parent f1c9cbc2a2
commit 5443ad5772
1 changed files with 5 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
clang/lib/Driver/Tools.cpp
View File

@@ -3570,25 +3570,19 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,
// -fmodule-name specifies the module that is currently being built (or
// used for header checking by -fmodule-maps).
if (Arg *A = Args.getLastArg(options::OPT_fmodule_name)) {
A->claim();
if (Arg *A = Args.getLastArg(options::OPT_fmodule_name))
A->render(Args, CmdArgs);
}
// -fmodule-map-file can be used to specify a file containing module
// definitions.
if (Arg *A = Args.getLastArg(options::OPT_fmodule_map_file)) {
A->claim();
if (Arg *A = Args.getLastArg(options::OPT_fmodule_map_file))
A->render(Args, CmdArgs);
}
// If a module path was provided, pass it along. Otherwise, use a temporary
// directory.
if (Arg *A = Args.getLastArg(options::OPT_fmodules_cache_path)) {
A->claim();
if (HaveModules) {
if (HaveModules)
A->render(Args, CmdArgs);
}
} else if (HaveModules) {
SmallString<128> DefaultModuleCache;
llvm::sys::path::system_temp_directory(/*erasedOnReboot=*/false,
@@ -3601,12 +3595,9 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,
CmdArgs.push_back(Args.MakeArgString(DefaultModuleCache));
}
if (Arg *A = Args.getLastArg(options::OPT_fmodules_user_build_path)) {
A->claim();
if (HaveModules) {
if (Arg *A = Args.getLastArg(options::OPT_fmodules_user_build_path))
if (HaveModules)
A->render(Args, CmdArgs);
}
}
// Pass through all -fmodules-ignore-macro arguments.
Args.AddAllArgs(CmdArgs, options::OPT_fmodules_ignore_macro);