intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-16 05:32:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

[lldb] [NFC] Remove unused WatchpointResource::SetID method (#79389)

Browse Source 
I originally thought to try to guesstimate the hardware watchpoint index
number that a Resource was associated with, but gdb remote serial
protocol doesn't give us the hardware register index used so it was only
a guess. I changed my mind and simply use ever-incrementing ID numbers
for the WatchpointResources, but forgot to remove the SetID method.
This commit is contained in:
Jason Molenda
2024-01-24 15:18:49 -08:00
committed by GitHub
parent bddeef54cb
commit 56da7991ea
2 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lldb/include/lldb/Breakpoint/WatchpointResource.h
View File

@@ -121,14 +121,6 @@ public:
/// A copy of the Watchpoints which own this resource.
WatchpointCollection CopyConstituentsList();
// The ID of the WatchpointResource is set by the WatchpointResourceList
// when the Resource has been set in the inferior and is being added
// to the List, in an attempt to match the hardware watchpoint register
// ordering. If a Process can correctly identify the hardware watchpoint
// register index when it has created the Resource, it may initialize it
// before it is inserted in the WatchpointResourceList.
void SetID(lldb::wp_resource_id_t);
lldb::wp_resource_id_t GetID() const;
bool Contains(lldb::addr_t addr);

2
lldb/source/Breakpoint/WatchpointResource.cpp
View File

@@ -42,8 +42,6 @@ void WatchpointResource::SetType(bool read, bool write) {
wp_resource_id_t WatchpointResource::GetID() const { return m_id; }
void WatchpointResource::SetID(wp_resource_id_t id) { m_id = id; }
bool WatchpointResource::Contains(addr_t addr) {
if (addr >= m_addr && addr < m_addr + m_size)
return true;