[NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy

Reported by Coverity:

    AUTO_CAUSES_COPY
    Unnecessary object copies can affect performance

    Inside FrontendActions.cpp file,
    In clang::DumpModuleInfoAction::ExecuteAction(): Using the auto keyword without an & causes the copy of an object of type pair.

    Inside ComputeDependence.cpp file,
    In clang::computeDependence(clang::OverloadExpr *, bool, bool, bool): Using the auto keyword without an & causes the copy of an object of type TemplateArgumentLoc.

    Reviewed By: erichkeane, aaron.ballman

    Differential Revision: https://reviews.llvm.org/D147574
This commit is contained in:
Manna, Soumi
2023-04-05 15:41:54 -04:00
parent c37b95b515
commit 59cb47015a
2 changed files with 2 additions and 2 deletions

View File

@@ -750,7 +750,7 @@ clang::computeDependence(OverloadExpr *E, bool KnownDependent,
// If we have explicit template arguments, check for dependent
// template arguments and whether they contain any unexpanded pack
// expansions.
for (auto A : E->template_arguments())
for (const auto &A : E->template_arguments())
Deps |= toExprDependence(A.getArgument().getDependence());
return Deps;
}

View File

@@ -882,7 +882,7 @@ void DumpModuleInfoAction::ExecuteAction() {
}
// Now let's print out any modules we did not see as part of the Primary.
for (auto SM : SubModMap) {
for (const auto &SM : SubModMap) {
if (!SM.second.Seen && SM.second.Mod) {
Out << " " << ModuleKindName(SM.second.Kind) << " '" << SM.first
<< "' at index #" << SM.second.Idx