intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-15 12:25:46 +08:00
Code Issues Packages Projects Releases Wiki Activity

[clang-tools-extra] Remove redundant calls to std::unique_ptr<T>::get (NFC) (#138774)

Browse Source
This commit is contained in:
Kazu Hirata
2025-05-06 20:16:54 -07:00
committed by GitHub
parent 796652dfc1
commit 5d305b618f
2 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp
View File

@@ -113,7 +113,7 @@ static SourceLocation getStartOfNextLine(SourceLocation Loc,
const SourceManager &SM,
const LangOptions &LangOpts) {
std::unique_ptr<Lexer> Lex = getLexerStartingFromLoc(Loc, SM, LangOpts);
if (!Lex.get())
if (!Lex)
return SourceLocation();
llvm::SmallVector<char, 16> Line;
// FIXME: this is a bit hacky to get ReadToEndOfLine work.
@@ -647,9 +647,8 @@ static SourceLocation getLocAfterNamespaceLBrace(const NamespaceDecl *NsDecl,
const LangOptions &LangOpts) {
std::unique_ptr<Lexer> Lex =
getLexerStartingFromLoc(NsDecl->getBeginLoc(), SM, LangOpts);
assert(Lex.get() &&
"Failed to create lexer from the beginning of namespace.");
if (!Lex.get())
assert(Lex && "Failed to create lexer from the beginning of namespace.");
if (!Lex)
return SourceLocation();
Token Tok;
while (!Lex->LexFromRawLexer(Tok) && Tok.isNot(tok::TokenKind::l_brace)) {

4
clang-tools-extra/clangd/unittests/PrerequisiteModulesTest.cpp
View File

@@ -545,8 +545,8 @@ void func() {
EXPECT_TRUE(Preamble);
EXPECT_TRUE(Preamble->RequiredModules);
auto Result = signatureHelp(getFullPath("Use.cpp"), Test.point(),
*Preamble.get(), Use, MarkupKind::PlainText);
auto Result = signatureHelp(getFullPath("Use.cpp"), Test.point(), *Preamble,
Use, MarkupKind::PlainText);
EXPECT_FALSE(Result.signatures.empty());
EXPECT_EQ(Result.signatures[0].label, "printA(int a) -> void");
EXPECT_EQ(Result.signatures[0].parameters[0].labelString, "int a");