intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-19 17:45:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

[lldb][NFCI] Timer::DumpCategoryTimes should take a reference instead of a pointer

Browse Source 
We are assuming that the pointer is always valid, might as well take a
reference instead.

Differential Revision: https://reviews.llvm.org/D153711
This commit is contained in:
Alex Langford
2023-06-24 12:33:12 -07:00
parent 718e0cd6e7
commit 5f69e6682b
4 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lldb/include/lldb/Utility/Timer.h
View File

@@ -56,7 +56,7 @@ public:
static void SetQuiet(bool value);
static void DumpCategoryTimes(Stream *s);
static void DumpCategoryTimes(Stream &s);
static void ResetCategoryTimes();

4
lldb/source/Commands/CommandObjectLog.cpp
View File

@@ -504,7 +504,7 @@ public:
protected:
bool DoExecute(Args &args, CommandReturnObject &result) override {
Timer::DumpCategoryTimes(&result.GetOutputStream());
Timer::DumpCategoryTimes(result.GetOutputStream());
Timer::SetDisplayDepth(0);
result.SetStatus(eReturnStatusSuccessFinishResult);
@@ -527,7 +527,7 @@ public:
protected:
bool DoExecute(Args &args, CommandReturnObject &result) override {
Timer::DumpCategoryTimes(&result.GetOutputStream());
Timer::DumpCategoryTimes(result.GetOutputStream());
result.SetStatus(eReturnStatusSuccessFinishResult);
if (!result.Succeeded()) {

12
lldb/source/Utility/Timer.cpp
View File

@@ -135,7 +135,7 @@ void Timer::ResetCategoryTimes() {
}
}
void Timer::DumpCategoryTimes(Stream *s) {
void Timer::DumpCategoryTimes(Stream &s) {
std::vector<Stats> sorted;
for (Category *i = g_categories; i; i = i->m_next) {
uint64_t nanos = i->m_nanos.load(std::memory_order_acquire);
@@ -153,9 +153,9 @@ void Timer::DumpCategoryTimes(Stream *s) {
llvm::sort(sorted, CategoryMapIteratorSortCriterion);
for (const auto &stats : sorted)
s->Printf("%.9f sec (total: %.3fs; child: %.3fs; count: %" PRIu64
") for %s\n",
stats.nanos / 1000000000., stats.nanos_total / 1000000000.,
(stats.nanos_total - stats.nanos) / 1000000000., stats.count,
stats.name);
s.Printf("%.9f sec (total: %.3fs; child: %.3fs; count: %" PRIu64
") for %s\n",
stats.nanos / 1000000000., stats.nanos_total / 1000000000.,
(stats.nanos_total - stats.nanos) / 1000000000., stats.count,
stats.name);
}

8
lldb/unittests/Utility/TimerTest.cpp
View File

@@ -21,7 +21,7 @@ TEST(TimerTest, CategoryTimes) {
std::this_thread::sleep_for(std::chrono::milliseconds(10));
}
StreamString ss;
Timer::DumpCategoryTimes(&ss);
Timer::DumpCategoryTimes(ss);
double seconds;
ASSERT_EQ(1, sscanf(ss.GetData(), "%lf sec for CAT1", &seconds));
EXPECT_LT(0.001, seconds);
@@ -39,7 +39,7 @@ TEST(TimerTest, CategoryTimesNested) {
std::this_thread::sleep_for(std::chrono::milliseconds(10));
}
StreamString ss;
Timer::DumpCategoryTimes(&ss);
Timer::DumpCategoryTimes(ss);
double seconds;
// It should only appear once.
ASSERT_EQ(ss.GetString().count("CAT1"), 1U);
@@ -59,7 +59,7 @@ TEST(TimerTest, CategoryTimes2) {
std::this_thread::sleep_for(std::chrono::milliseconds(10));
}
StreamString ss;
Timer::DumpCategoryTimes(&ss);
Timer::DumpCategoryTimes(ss);
double seconds1, seconds2;
ASSERT_EQ(2, sscanf(ss.GetData(),
"%lf sec (total: %*fs; child: %*fs; count: %*d) for "
@@ -92,7 +92,7 @@ TEST(TimerTest, CategoryTimesStats) {
// 0.105202764 sec (total: 0.132s; child: 0.027s; count: 1) for CAT1
// 0.026772798 sec (total: 0.027s; child: 0.000s; count: 2) for CAT2
StreamString ss;
Timer::DumpCategoryTimes(&ss);
Timer::DumpCategoryTimes(ss);
double seconds1, total1, child1, seconds2;
int count1, count2;
ASSERT_EQ(