intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-02-02 02:00:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

Small cleanup.

Browse Source 
* Use `cast` rather than `dyn_cast` to get an assertion failure rather than a segfault in case of a type mismatch.
    * Use stream operators to `emitOpError`s.

--

PiperOrigin-RevId: 249208135
This commit is contained in:
Thomas Joerg
2019-05-21 01:38:53 -07:00
committed by Mehdi Amini
parent c74996d199
commit 6c6f192b2c
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
mlir/lib/GPU/IR/GPUDialect.cpp
View File

@@ -303,7 +303,7 @@ void LaunchFuncOp::build(Builder *builder, OperationState *result,
}
Function *LaunchFuncOp::kernel() {
return this->getAttr(getKernelAttrName()).dyn_cast<FunctionAttr>().getValue();
return this->getAttr(getKernelAttrName()).cast<FunctionAttr>().getValue();
}
unsigned LaunchFuncOp::getNumKernelOperands() {
@@ -324,20 +324,20 @@ LogicalResult LaunchFuncOp::verify() {
Function *kernelFunc = this->kernel();
if (!kernelFunc->getAttrOfType<mlir::UnitAttr>(
GPUDialect::getKernelFuncAttrName())) {
return emitError("kernel function is missing the '" +
GPUDialect::getKernelFuncAttrName() + "' attribute");
return emitError("kernel function is missing the '")
<< GPUDialect::getKernelFuncAttrName() << "' attribute";
}
unsigned numKernelFuncArgs = kernelFunc->getNumArguments();
if (getNumKernelOperands() != numKernelFuncArgs) {
return emitOpError("got " + Twine(getNumKernelOperands()) +
" kernel operands but expected " +
Twine(numKernelFuncArgs));
return emitOpError("got ")
<< getNumKernelOperands() << " kernel operands but expected "
<< numKernelFuncArgs;
}
for (unsigned i = 0; i < numKernelFuncArgs; ++i) {
if (getKernelOperand(i)->getType() !=
kernelFunc->getArgument(i)->getType()) {
return emitOpError("type of function argument " + Twine(i) +
" does not match");
return emitOpError("type of function argument ")
<< i << " does not match";
}
}
return success();