intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-02-02 10:08:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

[C++20] [Modules] Handle reachability for partial specialization

Browse Source 
Previously we don't catch the reachability for partial specialization.
Handle them in this patch.
This commit is contained in:
Chuanqi Xu
2022-07-22 17:03:38 +08:00
parent f359eac5df
commit 6d9b84797c
2 changed files with 36 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
clang/lib/Sema/SemaTemplate.cpp
View File

@@ -4573,7 +4573,7 @@ Sema::CheckVarTemplateId(VarTemplateDecl *Template, SourceLocation TemplateLoc,
void *InsertPos = nullptr;
if (VarTemplateSpecializationDecl *Spec = Template->findSpecialization(
Converted, InsertPos)) {
checkSpecializationVisibility(TemplateNameLoc, Spec);
checkSpecializationReachability(TemplateNameLoc, Spec);
// If we already have a variable template specialization, return it.
return Spec;
}
@@ -4694,7 +4694,7 @@ Sema::CheckVarTemplateId(VarTemplateDecl *Template, SourceLocation TemplateLoc,
dyn_cast<VarTemplatePartialSpecializationDecl>(InstantiationPattern))
Decl->setInstantiationOf(D, InstantiationArgs);
checkSpecializationVisibility(TemplateNameLoc, Decl);
checkSpecializationReachability(TemplateNameLoc, Decl);
assert(Decl && "No variable template specialization?");
return Decl;

34
clang/test/Modules/partial_specialization.cppm Normal file
View File

@@ -0,0 +1,34 @@
// RUN: rm -rf %t
// RUN: split-file %s %t
// RUN: cd %t
//
// RUN: %clang_cc1 -std=c++20 -emit-module-interface %t/A.cppm -o %t/A.pcm
// RUN: %clang_cc1 -std=c++20 -fprebuilt-module-path=%t %t/Use.cpp -fsyntax-only -verify
//
//--- foo.h
template<typename T, typename U>
inline constexpr bool IsSame = false;
template<typename T>
inline constexpr bool IsSame<T, T> = true;
template <typename T>
class A {
public:
A();
~A() noexcept(IsSame<T, T>);
};
//--- A.cppm
module;
#include "foo.h"
export module A;
export using ::A;
//--- Use.cpp
import A;
void bool_consume(bool b);
void use() {
A<int> a{};
bool_consume(IsSame); // expected-error {{use of undeclared identifier 'IsSame'}}
}