Don't spam warnings about not being able to read memory at 0x0.

llvm-svn: 146271
This commit is contained in:
Jim Ingham
2011-12-09 19:48:22 +00:00
parent f85723626c
commit 703588540e

View File

@@ -85,7 +85,10 @@ MachVMMemory::Read(task_t task, nub_addr_t address, void *data, nub_size_t data_
mach_msg_type_number_t curr_bytes_read = 0;
vm_offset_t vm_memory = NULL;
m_err = ::mach_vm_read (task, curr_addr, curr_size, &vm_memory, &curr_bytes_read);
if (DNBLogCheckLogBit(LOG_MEMORY) || m_err.Fail())
// We end up being asked to read memory at 0x0 a lot without that being a real error, so that ends up just
// causing a lot of useless log spam. Only complain on failing reads if the address is not 0x0.
if (DNBLogCheckLogBit(LOG_MEMORY) || (m_err.Fail() && curr_addr != 0))
m_err.LogThreaded("::mach_vm_read ( task = 0x%4.4x, addr = 0x%8.8llx, size = %llu, data => %8.8p, dataCnt => %i )", task, (uint64_t)curr_addr, (uint64_t)curr_size, vm_memory, curr_bytes_read);
if (m_err.Success())