intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-24 08:30:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

[libomptarget] [amdgpu] Hostcall offset check should consider implicit args

Browse Source 
Fixed hostcall offset check to compare against kernarg segment size
and implicit arguments. Improved the corresponding debug print.

Reviewed By: JonChesterfield

Differential Revision: https://reviews.llvm.org/D123827
This commit is contained in:
Dhruva Chakrabarti
2022-04-14 23:38:49 +00:00
parent e33b07f859
commit 7086a1db80
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
openmp/libomptarget/plugins/amdgpu/src/rtl.cpp
View File

@@ -1240,6 +1240,8 @@ int32_t runRegionLocked(int32_t device_id, void *tgt_entry_ptr, void **tgt_args,
return OFFLOAD_FAIL;
}
DP("Implicit argument count: %d\n",
KernelInfoEntry.implicit_argument_count);
if (KernelInfoEntry.implicit_argument_count >= 4) {
// Initialise pointer for implicit_argument_count != 0 ABI
// Guess that the right implicit argument is at offset 24 after
@@ -1247,8 +1249,10 @@ int32_t runRegionLocked(int32_t device_id, void *tgt_entry_ptr, void **tgt_args,
// the offset from msgpack. Clang is not annotating it at present.
uint64_t Offset =
sizeof(void *) * (KernelInfoEntry.explicit_argument_count + 3);
if ((Offset + 8) > (ArgPool->kernarg_segment_size)) {
DP("Bad offset of hostcall, exceeds kernarg segment size\n");
if ((Offset + 8) > ArgPool->kernarg_size_including_implicit()) {
DP("Bad offset of hostcall: %lu, exceeds kernarg size w/ implicit "
"args: %d\n",
Offset + 8, ArgPool->kernarg_size_including_implicit());
} else {
memcpy(static_cast<char *>(kernarg) + Offset, &buffer, 8);
}