intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-17 14:48:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

[LLDB] Fix remote executables load and caching (#98623)

Browse Source 
Seemingly, #96256 removed the only call to
Platform::GetCachedExecutable, which broke the resolution of executable
modules in the remote debugging mode
(https://github.com/llvm/llvm-project/issues/97410).

This commit fixes that.
This commit is contained in:
Vladislav Dzhidzhoev
2024-07-12 20:43:08 +02:00
committed by GitHub
parent b96c0123fd
commit 73dad7a765
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lldb/source/Target/Platform.cpp
View File

@@ -1446,7 +1446,8 @@ Platform::GetCachedExecutable(ModuleSpec &module_spec,
Status error = GetRemoteSharedModule(
module_spec, nullptr, module_sp,
[&](const ModuleSpec &spec) {
return ResolveExecutable(spec, module_sp, module_search_paths_ptr);
return Platform::ResolveExecutable(spec, module_sp,
module_search_paths_ptr);
},
nullptr);
if (error.Success()) {

3
lldb/source/Target/RemoteAwarePlatform.cpp
View File

@@ -46,6 +46,9 @@ Status RemoteAwarePlatform::ResolveExecutable(
if (!FileSystem::Instance().Exists(resolved_file_spec))
FileSystem::Instance().ResolveExecutableLocation(resolved_file_spec);
} else if (m_remote_platform_sp) {
return GetCachedExecutable(resolved_module_spec, exe_module_sp,
module_search_paths_ptr);
}
return Platform::ResolveExecutable(resolved_module_spec, exe_module_sp,