intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-30 14:07:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

implement a fixme by making warnings for ++/-- on non-modifiable-lvalues better.

Browse Source 
llvm-svn: 59484
This commit is contained in:
Chris Lattner
2008-11-18 01:26:17 +00:00
parent 30bd327746
commit 74112917b2
3 changed files with 4 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
clang/include/clang/Basic/DiagnosticKinds.def
View File

@@ -1086,8 +1086,6 @@ DIAG(err_typecheck_no_member, ERROR,
"no member named '%0'")
DIAG(err_typecheck_illegal_increment_decrement, ERROR,
"cannot modify value of type '%0'")
DIAG(err_typecheck_invalid_lvalue_incr_decr, ERROR,
"invalid lvalue in increment/decrement expression")
DIAG(err_typecheck_arithmetic_incomplete_type, ERROR,
"arithmetic on pointer to incomplete type '%0'")
DIAG(err_typecheck_decl_incomplete_type, ERROR,

9
clang/lib/Sema/SemaExpr.cpp
View File

@@ -2368,7 +2368,7 @@ static bool CheckForModifiableLvalue(Expr *E, SourceLocation Loc, Sema &S) {
}
if (NeedType)
S.Diag(Loc, Diag, E->getType().getAsString(), SR);
S.Diag(Loc, Diag, E->getType().getAsString(), E->getSourceRange());
else
S.Diag(Loc, Diag, E->getSourceRange());
return true;
@@ -2463,13 +2463,8 @@ QualType Sema::CheckIncrementDecrementOperand(Expr *op, SourceLocation OpLoc) {
}
// At this point, we know we have a real, complex or pointer type.
// Now make sure the operand is a modifiable lvalue.
Expr::isModifiableLvalueResult mlval = op->isModifiableLvalue(Context);
if (mlval != Expr::MLV_Valid) {
// FIXME: emit a more precise diagnostic...
Diag(OpLoc, diag::err_typecheck_invalid_lvalue_incr_decr,
op->getSourceRange());
if (CheckForModifiableLvalue(op, OpLoc, *this))
return QualType();
}
return resType;
}

4
clang/test/SemaCXX/decl-expr-ambiguity.cpp
View File

@@ -7,8 +7,8 @@ void f() {
// Expressions.
T(a)->m = 7;
int(a)++; // expected-error {{invalid lvalue in increment/decrement expression}}
__extension__ int(a)++; // expected-error {{invalid lvalue in increment/decrement expression}}
int(a)++; // expected-error {{expression is not assignable}}
__extension__ int(a)++; // expected-error {{expression is not assignable}}
typeof(int)(a,5)<<a; // expected-error {{function-style cast to a builtin type can only take one argument}}
void(a), ++a; // expected-warning {{statement was disambiguated as expression}} expected-warning {{expression result unused}}
if (int(a)+1) {}