intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-16 05:32:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

[BOLT] Support files with no symbols

Browse Source 
`LastSymbol` handling in `discoverFileObjects` assumes a non-zero number of
symbols in an object file. It's not the case for broken_dynsym.test added in
D130073, and potentially other stripped binaries.

Reviewed By: maksfb

Differential Revision: https://reviews.llvm.org/D130544
This commit is contained in:
Amir Ayupov
2022-07-26 00:07:34 -07:00
parent 8a13326d18
commit 77c1977384
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
bolt/lib/Rewrite/RewriteInstance.cpp
View File

@@ -866,7 +866,9 @@ void RewriteInstance::discoverFileObjects() {
llvm::stable_sort(SortedFileSymbols, CompareSymbols);
auto LastSymbol = SortedFileSymbols.end() - 1;
auto LastSymbol = SortedFileSymbols.end();
if (!SortedFileSymbols.empty())
--LastSymbol;
// For aarch64, the ABI defines mapping symbols so we identify data in the
// code section (see IHI0056B). $d identifies data contents.
@@ -912,13 +914,16 @@ void RewriteInstance::discoverFileObjects() {
LastSymbol = std::stable_partition(
SortedFileSymbols.begin(), SortedFileSymbols.end(),
[this](const SymbolRef &Symbol) { return !BC->isMarker(Symbol); });
--LastSymbol;
if (!SortedFileSymbols.empty())
--LastSymbol;
}
BinaryFunction *PreviousFunction = nullptr;
unsigned AnonymousId = 0;
const auto SortedSymbolsEnd = std::next(LastSymbol);
const auto SortedSymbolsEnd = LastSymbol == SortedFileSymbols.end()
? LastSymbol
: std::next(LastSymbol);
for (auto ISym = SortedFileSymbols.begin(); ISym != SortedSymbolsEnd;
++ISym) {
const SymbolRef &Symbol = *ISym;