intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-27 06:06:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

[runtimes] Workaround a subtle linker issue on macOS in the CI

Browse Source
This commit is contained in:
Louis Dionne
2023-09-21 11:29:19 -04:00
parent e6f9483f77
commit 7fcbb64fca
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
libcxx/utils/ci/run-buildbot
View File

@@ -162,9 +162,6 @@ function generate-cmake-libcxx-win() {
}
function check-runtimes() {
echo "--- Installing libc++, libc++abi and libunwind to a fake location"
${NINJA} -vC "${BUILD_DIR}" install-cxx install-cxxabi install-unwind
echo "+++ Running the libc++ tests"
${NINJA} -vC "${BUILD_DIR}" check-cxx
@@ -173,6 +170,19 @@ function check-runtimes() {
echo "+++ Running the libunwind tests"
${NINJA} -vC "${BUILD_DIR}" check-unwind
# TODO: On macOS 13.5, the linker seems to have an issue where it will pick up
# a library if it exists inside a -L search path, even if we don't link
# against that library. This happens with libunwind.dylib if it is built
# at the point when we run the libc++ tests, which causes issues cause we
# are also linking against the system unwinder.
#
# I believe this is a linker regression and I reported it as rdar://115842730.
# It should be possible to move this installation step back to the top once
# that issue has been resolved, but in the meantime it doesn't really hurt to
# have it here.
echo "--- Installing libc++, libc++abi and libunwind to a fake location"
${NINJA} -vC "${BUILD_DIR}" install-cxx install-cxxabi install-unwind
}
# TODO: The goal is to test this against all configurations. We should also move