intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-22 23:49:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Expression] Remove unused parameter from Evaluate

Browse Source 
llvm-svn: 355375
This commit is contained in:
Alex Langford
2019-03-05 03:33:34 +00:00
parent 013e17f50e
commit 81dbc02671
4 changed files with 7 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lldb/include/lldb/Expression/UserExpression.h
View File

@@ -261,10 +261,6 @@ public:
/// Filled in with an error in case the expression evaluation
/// fails to parse, run, or evaluated.
///
/// @param[in] line_offset
/// The offset of the first line of the expression from the "beginning" of
/// a virtual source file used for error reporting and debug info.
///
/// @param[out] fixed_expression
/// If non-nullptr, the fixed expression is copied into the provided
/// string.
@@ -290,7 +286,7 @@ public:
Evaluate(ExecutionContext &exe_ctx, const EvaluateExpressionOptions &options,
llvm::StringRef expr_cstr, llvm::StringRef expr_prefix,
lldb::ValueObjectSP &result_valobj_sp, Status &error,
uint32_t line_offset = 0, std::string *fixed_expression = nullptr,
std::string *fixed_expression = nullptr,
lldb::ModuleSP *jit_module_sp_ptr = nullptr,
ValueObject *ctx_obj = nullptr);

1
lldb/source/Expression/REPL.cpp
View File

@@ -307,7 +307,6 @@ void REPL::IOHandlerInputComplete(IOHandler &io_handler, std::string &code) {
lldb::ExpressionResults execution_results =
UserExpression::Evaluate(exe_ctx, expr_options, code.c_str(),
expr_prefix, result_valobj_sp, error,
0, // Line offset
nullptr, // Fixed Expression
&jit_module_sp);

2
lldb/source/Expression/UserExpression.cpp
View File

@@ -139,7 +139,7 @@ lldb::addr_t UserExpression::GetObjectPointer(lldb::StackFrameSP frame_sp,
lldb::ExpressionResults UserExpression::Evaluate(
ExecutionContext &exe_ctx, const EvaluateExpressionOptions &options,
llvm::StringRef expr, llvm::StringRef prefix,
lldb::ValueObjectSP &result_valobj_sp, Status &error, uint32_t line_offset,
lldb::ValueObjectSP &result_valobj_sp, Status &error,
std::string *fixed_expression, lldb::ModuleSP *jit_module_sp_ptr,
ValueObject *ctx_obj) {
Log *log(lldb_private::GetLogIfAnyCategoriesSet(LIBLLDB_LOG_EXPRESSIONS |

11
lldb/source/Target/Target.cpp
View File

@@ -2401,12 +2401,11 @@ ExpressionResults Target::EvaluateExpression(
} else {
llvm::StringRef prefix = GetExpressionPrefixContents();
Status error;
execution_results = UserExpression::Evaluate(exe_ctx, options, expr, prefix,
result_valobj_sp, error,
0, // Line Number
fixed_expression,
nullptr, // Module
ctx_obj);
execution_results =
UserExpression::Evaluate(exe_ctx, options, expr, prefix,
result_valobj_sp, error, fixed_expression,
nullptr, // Module
ctx_obj);
}
m_suppress_stop_hooks = old_suppress_value;