intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-21 03:46:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

[lldb][NFCI] Remove unused member from ObjectFileMachO

Browse Source 
From what I can see, `m_mach_segments` is completely unused. Let's
remove it.

Differential Revision: https://reviews.llvm.org/D151236
This commit is contained in:
Alex Langford
2023-05-23 10:35:32 -07:00
parent 99e880b672
commit 973f1fe7a8
2 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
View File

@@ -940,9 +940,9 @@ ObjectFileMachO::ObjectFileMachO(const lldb::ModuleSP &module_sp,
lldb::offset_t file_offset,
lldb::offset_t length)
: ObjectFile(module_sp, file, file_offset, length, data_sp, data_offset),
m_mach_segments(), m_mach_sections(), m_entry_point_address(),
m_thread_context_offsets(), m_thread_context_offsets_valid(false),
m_reexported_dylibs(), m_allow_assembly_emulation_unwind_plans(true) {
m_mach_sections(), m_entry_point_address(), m_thread_context_offsets(),
m_thread_context_offsets_valid(false), m_reexported_dylibs(),
m_allow_assembly_emulation_unwind_plans(true) {
::memset(&m_header, 0, sizeof(m_header));
::memset(&m_dysymtab, 0, sizeof(m_dysymtab));
}
@@ -952,9 +952,9 @@ ObjectFileMachO::ObjectFileMachO(const lldb::ModuleSP &module_sp,
const lldb::ProcessSP &process_sp,
lldb::addr_t header_addr)
: ObjectFile(module_sp, process_sp, header_addr, header_data_sp),
m_mach_segments(), m_mach_sections(), m_entry_point_address(),
m_thread_context_offsets(), m_thread_context_offsets_valid(false),
m_reexported_dylibs(), m_allow_assembly_emulation_unwind_plans(true) {
m_mach_sections(), m_entry_point_address(), m_thread_context_offsets(),
m_thread_context_offsets_valid(false), m_reexported_dylibs(),
m_allow_assembly_emulation_unwind_plans(true) {
::memset(&m_header, 0, sizeof(m_header));
::memset(&m_dysymtab, 0, sizeof(m_dysymtab));
}
@@ -1622,10 +1622,6 @@ void ObjectFileMachO::ProcessSegmentCommand(
const bool segment_is_encrypted =
(load_cmd.flags & SG_PROTECTED_VERSION_1) != 0;
// Keep a list of mach segments around in case we need to get at data that
// isn't stored in the abstracted Sections.
m_mach_segments.push_back(load_cmd);
// Use a segment ID of the segment index shifted left by 8 so they never
// conflict with any of the sections.
SectionSP segment_sp;

1
lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h
View File

@@ -269,7 +269,6 @@ protected:
static lldb_private::ConstString GetSectionNameEHFrame();
llvm::MachO::dysymtab_command m_dysymtab;
std::vector<llvm::MachO::segment_command_64> m_mach_segments;
std::vector<llvm::MachO::section_64> m_mach_sections;
std::optional<llvm::VersionTuple> m_min_os_version;
std::optional<llvm::VersionTuple> m_sdk_versions;