intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-25 10:55:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

[clang][dataflow][NFC] Remove unused parameter from insertIfGlobal().

Browse Source 
Reviewed By: gribozavr2

Differential Revision: https://reviews.llvm.org/D148004
This commit is contained in:
Martin Braenne
2023-04-11 10:21:25 +00:00
parent 271853c62f
commit 991c7e1172
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp
View File

@@ -156,7 +156,6 @@ static Value &widenDistinctValues(QualType Type, Value &Prev,
/// Initializes a global storage value.
static void insertIfGlobal(const Decl &D,
llvm::DenseSet<const FieldDecl *> &Fields,
llvm::DenseSet<const VarDecl *> &Vars) {
if (auto *V = dyn_cast<VarDecl>(&D))
if (V->hasGlobalStorage())
@@ -166,7 +165,7 @@ static void insertIfGlobal(const Decl &D,
static void getFieldsAndGlobalVars(const Decl &D,
llvm::DenseSet<const FieldDecl *> &Fields,
llvm::DenseSet<const VarDecl *> &Vars) {
insertIfGlobal(D, Fields, Vars);
insertIfGlobal(D, Vars);
if (const auto *Decomp = dyn_cast<DecompositionDecl>(&D))
for (const auto *B : Decomp->bindings())
if (auto *ME = dyn_cast_or_null<MemberExpr>(B->getBinding()))
@@ -191,11 +190,11 @@ static void getFieldsAndGlobalVars(const Stmt &S,
for (auto *D : DS->getDeclGroup())
getFieldsAndGlobalVars(*D, Fields, Vars);
} else if (auto *E = dyn_cast<DeclRefExpr>(&S)) {
insertIfGlobal(*E->getDecl(), Fields, Vars);
insertIfGlobal(*E->getDecl(), Vars);
} else if (auto *E = dyn_cast<MemberExpr>(&S)) {
// FIXME: should we be using `E->getFoundDecl()`?
const ValueDecl *VD = E->getMemberDecl();
insertIfGlobal(*VD, Fields, Vars);
insertIfGlobal(*VD, Vars);
if (const auto *FD = dyn_cast<FieldDecl>(VD))
Fields.insert(FD);
}