intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-02-08 08:57:43 +08:00
Code Issues Packages Projects Releases Wiki Activity

Enhance reference-count checker to correctly identify CG "release" functions. This fixes <rdar://problem/6303488>.

Browse Source 
llvm-svn: 57997
This commit is contained in:
Ted Kremenek
2008-10-22 20:54:52 +00:00
parent 1df62692f2
commit 9a96bf22ec
2 changed files with 31 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
clang/lib/Analysis/CFRefCount.cpp
View File

@@ -704,8 +704,12 @@ RetainSummary* RetainSummaryManager::getSummary(FunctionDecl* FD) {
}
}
if (FName[0] == 'C' && FName[1] == 'F')
S = getCFSummary(FD, FName);
if (FName[0] == 'C') {
if (FName[1] == 'F')
S = getCFSummary(FD, FName);
else if (FName[1] == 'G')
S = getCGSummary(FD, FName);
}
else if (FName[0] == 'N' && FName[1] == 'S')
S = getNSSummary(FD, FName);
}
@@ -834,10 +838,14 @@ RetainSummary* RetainSummaryManager::getCFSummaryCreateRule(FunctionDecl* FD) {
FunctionType* FT =
dyn_cast<FunctionType>(FD->getType().getTypePtr());
if (FT && !isCFRefType(FT->getResultType()))
return getPersistentSummary(RetEffect::MakeNoRet());
if (FT) {
QualType ResTy = FT->getResultType();
if (!isCFRefType(ResTy) && !isCGRefType(ResTy))
return getPersistentSummary(RetEffect::MakeNoRet());
}
assert (ScratchArgs.empty());
if (FD->getIdentifier() == CFDictionaryCreateII) {

18
clang/test/Analysis/CGColorSpace.c Normal file
View File

@@ -0,0 +1,18 @@
// clang -checker-cfref -verify %s
typedef struct CGColorSpace *CGColorSpaceRef;
extern CGColorSpaceRef CGColorSpaceCreateDeviceRGB(void);
extern CGColorSpaceRef CGColorSpaceRetain(CGColorSpaceRef space);
extern void CGColorSpaceRelease(CGColorSpaceRef space);
void f() {
CGColorSpaceRef X = CGColorSpaceCreateDeviceRGB();
CGColorSpaceRetain(X); // expected-warning{{leak}}
}
void fb() {
CGColorSpaceRef X = CGColorSpaceCreateDeviceRGB();
CGColorSpaceRetain(X);
CGColorSpaceRelease(X);
CGColorSpaceRelease(X); // no-warning
}