intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-21 12:19:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

[MLIR] Incorrect track of usedKey in setPropertiesFromParsedAttr (#144789)

Browse Source 
co-authored by @chencha3 and @joker-eph
This commit is contained in:
Chao Chen
2025-06-20 10:02:09 -05:00
committed by GitHub
parent b017b4ce9a
commit 9dc59cc95b
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
mlir/test/lib/Dialect/Test/TestOps.td
View File

@@ -3179,7 +3179,7 @@ def TestOpWithPropertiesAndInferredType
]> {
let assemblyFormat = "$lhs prop-dict attr-dict";
let arguments = (ins I32Attr:$lhs, IntProp<"int64_t">:$rhs);
let arguments = (ins I32Attr:$lhs, IntProp<"int64_t">:$rhs, OptionalAttr<UnitAttr>: $packed);
let results = (outs AnyType:$result);
}

4
mlir/test/mlir-tblgen/op-format.mlir
View File

@@ -516,8 +516,8 @@ test.format_infer_variadic_type_from_non_variadic %i64, %i64 : i64
// CHECK: test.with_properties_and_attr 16 < {rhs = 16 : i64}>
test.with_properties_and_attr 16 <{rhs = 16 : i64}>
// CHECK: test.with_properties_and_inferred_type 16 < {rhs = 16 : i64}>
%should_be_i32 = test.with_properties_and_inferred_type 16 <{rhs = 16 : i64}>
// CHECK: test.with_properties_and_inferred_type 16 < {packed, rhs = 16 : i64}>
%should_be_i32 = test.with_properties_and_inferred_type 16 <{packed, rhs = 16 : i64}>
// Assert through the verifier that its inferred as i32.
test.format_all_types_match_var %should_be_i32, %i32 : i32

2
mlir/tools/mlir-tblgen/OpFormatGen.cpp
View File

@@ -1365,7 +1365,7 @@ if (attr && ::mlir::failed(setFromAttr(prop.{1}, attr, emitError)))
auto &propStorage = prop.{0};
auto {0}AttrName = StringAttr::get(ctx, "{0}");
auto attr = dict.get({0}AttrName);
usedKeys.insert(StringAttr::get(ctx, "{1}"));
usedKeys.insert({0}AttrName);
if (attr || /*isRequired=*/{1}) {{
if (!attr) {{
emitError() << "expected key entry for {0} in DictionaryAttr to set "