intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-13 02:38:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

[lldb][mcp] Fix unix domain socket protocol server addresses (#146603)

Browse Source 
When starting an MCP protocol server that uses unix sockets as the
transport, a local `'[0.0.0.0]:0'` file is used instead of the supplied
socket path, e.g:
```
(lldb) protocol-server start MCP accept:///tmp/some/path.sock
MCP server started with connection listeners: unix-connect://[0.0.0.0]:0
(lldb) shell ls '[*'
[0.0.0.0]:0
```

This change makes it so that the URI path is used if the socket protocol
is `ProtocolUnixDomain`:
```
(lldb) protocol-server start MCP accept:///tmp/some/path.sock
MCP server started with connection listeners: unix-connect:///tmp/some/path.sock
```
This commit is contained in:
Alexandre Perez
2025-07-02 17:03:05 -07:00
committed by GitHub
parent f01017ca97
commit a068ed288a
2 changed files with 40 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lldb/source/Commands/CommandObjectProtocolServer.cpp
View File

@@ -75,9 +75,12 @@ protected:
ProtocolServer::Connection connection;
connection.protocol = protocol_and_mode->first;
connection.name =
formatv("[{0}]:{1}", uri->hostname.empty() ? "0.0.0.0" : uri->hostname,
uri->port.value_or(0));
if (connection.protocol == Socket::SocketProtocol::ProtocolUnixDomain)
connection.name = uri->path;
else
connection.name = formatv(
"[{0}]:{1}", uri->hostname.empty() ? "0.0.0.0" : uri->hostname,
uri->port.value_or(0));
if (llvm::Error error = server->Start(connection)) {
result.AppendErrorWithFormatv("{0}", llvm::fmt_consume(std::move(error)));
@@ -90,6 +93,7 @@ protected:
result.AppendMessageWithFormatv(
"{0} server started with connection listeners: {1}", protocol,
address);
result.SetStatus(eReturnStatusSuccessFinishNoResult);
}
}
};

33
lldb/test/API/commands/protocol/TestMCPUnixSocket.py Normal file
View File

@@ -0,0 +1,33 @@
import os
import tempfile
import unittest
from lldbsuite.test.decorators import *
from lldbsuite.test.lldbtest import *
# To be safe and portable, Unix domain socket paths should be kept at or below
# 108 characters on Linux, and around 104 characters on macOS:
MAX_SOCKET_PATH_LENGTH = 104
class MCPUnixSocketCommandTestCase(TestBase):
@skipIfWindows
@no_debug_info_test
def test_unix_socket(self):
"""
Test if we can start an MCP protocol-server accepting unix sockets
"""
temp_directory = tempfile.TemporaryDirectory()
socket_file = os.path.join(temp_directory.name, "mcp.sock")
if len(socket_file) >= MAX_SOCKET_PATH_LENGTH:
self.skipTest(
f"Socket path {socket_file} exceeds the {MAX_SOCKET_PATH_LENGTH} character limit"
)
self.expect(
f"protocol-server start MCP accept://{socket_file}",
startstr="MCP server started with connection listeners:",
substrs=[f"unix-connect://{socket_file}"],
)