intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-16 21:55:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

[clang-tidy] Fix an abseil-redundant-strcat-calls crash on 0-parameter StrCat().

Browse Source 
Differential Revision: https://reviews.llvm.org/D91601
This commit is contained in:
Haojian Wu
2020-11-17 10:26:44 +01:00
parent 3a5c0ea895
commit af0d607e72
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
clang-tools-extra/clang-tidy/abseil/RedundantStrcatCallsCheck.cpp
View File

@@ -47,6 +47,8 @@ struct StrCatCheckResult {
};
void RemoveCallLeaveArgs(const CallExpr* Call, StrCatCheckResult* CheckResult) {
if (Call->getNumArgs() == 0)
return;
// Remove 'Foo('
CheckResult->Hints.push_back(
FixItHint::CreateRemoval(CharSourceRange::getCharRange(

4
clang-tools-extra/test/clang-tidy/checkers/abseil-redundant-strcat-calls.cpp
View File

@@ -121,6 +121,7 @@ struct AlphaNum {
AlphaNum &operator=(const AlphaNum &);
};
string StrCat();
string StrCat(const AlphaNum &A);
string StrCat(const AlphaNum &A, const AlphaNum &B);
string StrCat(const AlphaNum &A, const AlphaNum &B, const AlphaNum &C);
@@ -182,6 +183,9 @@ void Positives() {
StrAppend(&S, StrCat(1, 2, 3, 4, 5), StrCat(6, 7, 8, 9, 10));
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: multiple calls to 'absl::StrCat' can be flattened into a single call
// CHECK-FIXES: StrAppend(&S, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10);
StrCat(1, StrCat());
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: multiple calls to 'absl::StrCat' can be flattened into a single call
}
void Negatives() {