mirror of
https://github.com/intel/llvm.git
synced 2026-02-09 01:52:26 +08:00
[NFC] Add GitHub issues to HLSL FIXME comments
In order to make this easier to track I've filed issues for each of the HLSL FIXME comments that I can find. I may have missed some, but I want this to be the new default mode.
This commit is contained in:
@@ -143,6 +143,7 @@ void CGHLSLRuntime::emitEntryFunction(const FunctionDecl *FD,
|
||||
IRBuilder<> B(BB);
|
||||
llvm::SmallVector<Value *> Args;
|
||||
// FIXME: support struct parameters where semantics are on members.
|
||||
// See: https://github.com/llvm/llvm-project/issues/57874
|
||||
for (const auto *Param : FD->parameters()) {
|
||||
Args.push_back(emitInputSemantic(B, *Param));
|
||||
}
|
||||
@@ -150,6 +151,7 @@ void CGHLSLRuntime::emitEntryFunction(const FunctionDecl *FD,
|
||||
CallInst *CI = B.CreateCall(FunctionCallee(Fn), Args);
|
||||
(void)CI;
|
||||
// FIXME: Handle codegen for return type semantics.
|
||||
// See: https://github.com/llvm/llvm-project/issues/57875
|
||||
B.CreateRetVoid();
|
||||
}
|
||||
|
||||
|
||||
@@ -209,5 +209,6 @@ HLSLToolChain::TranslateArgs(const DerivedArgList &Args, StringRef BoundArch,
|
||||
}
|
||||
// FIXME: add validation for enable_16bit_types should be after HLSL 2018 and
|
||||
// shader model 6.2.
|
||||
// See: https://github.com/llvm/llvm-project/issues/57876
|
||||
return DAL;
|
||||
}
|
||||
|
||||
@@ -11896,6 +11896,7 @@ void Sema::CheckHLSLEntryPoint(FunctionDecl *FD) {
|
||||
for (const auto *Param : FD->parameters()) {
|
||||
if (!Param->hasAttr<HLSLAnnotationAttr>()) {
|
||||
// FIXME: Handle struct parameters where annotations are on struct fields.
|
||||
// See: https://github.com/llvm/llvm-project/issues/57875
|
||||
Diag(FD->getLocation(), diag::err_hlsl_missing_semantic_annotation);
|
||||
Diag(Param->getLocation(), diag::note_previous_decl) << Param;
|
||||
FD->setInvalidDecl();
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
// RUN: %clang -cc1 -S -triple dxil-pc-shadermodel6.3-library -S -emit-llvm -xhlsl -validator-version 1.1 -o - %s | FileCheck %s
|
||||
|
||||
// FIXME:The following line should work once SPIR-V support for HLSL is added.
|
||||
// See: https://github.com/llvm/llvm-project/issues/57877
|
||||
// DISABLED: %clang -cc1 -S -triple spirv32 -S -emit-llvm -xhlsl -validator-version 1.1 -o - %s | FileCheck %s --check-prefix=NOT_DXIL
|
||||
|
||||
// CHECK:!dx.valver = !{![[valver:[0-9]+]]}
|
||||
|
||||
Reference in New Issue
Block a user