intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-21 20:53:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

[debugserver] Move constants into TaskPortForProcessID (NFC) (#166670)

Browse Source 
I was looking at the calls to `usleep` in debugserver and noticed that
these default arguments are never overwritten. I converted them to
constants in the function, which makes it easier to reason about.
This commit is contained in:
Jonas Devlieghere
2025-11-05 16:32:36 -08:00
committed by GitHub
parent d2b43ffffc
commit bd9030e762
2 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lldb/tools/debugserver/source/MacOSX/MachTask.h
View File

@@ -81,9 +81,7 @@ public:
void TaskPortChanged(task_t task);
task_t TaskPort() const { return m_task; }
task_t TaskPortForProcessID(DNBError &err, bool force = false);
static task_t TaskPortForProcessID(pid_t pid, DNBError &err,
uint32_t num_retries = 10,
uint32_t usec_interval = 10000);
static task_t TaskPortForProcessID(pid_t pid, DNBError &err);
MachProcess *Process() { return m_process; }
const MachProcess *Process() const { return m_process; }

11
lldb/tools/debugserver/source/MacOSX/MachTask.mm
View File

@@ -523,14 +523,15 @@ task_t MachTask::TaskPortForProcessID(DNBError &err, bool force) {
//----------------------------------------------------------------------
// MachTask::TaskPortForProcessID
//----------------------------------------------------------------------
task_t MachTask::TaskPortForProcessID(pid_t pid, DNBError &err,
uint32_t num_retries,
uint32_t usec_interval) {
task_t MachTask::TaskPortForProcessID(pid_t pid, DNBError &err) {
static constexpr uint32_t k_num_retries = 10;
static constexpr uint32_t k_usec_delay = 10000;
if (pid != INVALID_NUB_PROCESS) {
DNBError err;
mach_port_t task_self = mach_task_self();
task_t task = TASK_NULL;
for (uint32_t i = 0; i < num_retries; i++) {
for (uint32_t i = 0; i < k_num_retries; i++) {
DNBLog("[LaunchAttach] (%d) about to task_for_pid(%d)", getpid(), pid);
err = ::task_for_pid(task_self, pid, &task);
@@ -557,7 +558,7 @@ task_t MachTask::TaskPortForProcessID(pid_t pid, DNBError &err,
}
// Sleep a bit and try again
::usleep(usec_interval);
::usleep(k_usec_delay);
}
}
return TASK_NULL;