intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-27 14:50:42 +08:00
Code Issues Packages Projects Releases Wiki Activity

[FIX] Prevent division/modulo by zero in parameters

Browse Source 
When we materialize parameter SCEVs we did so without considering the
  side effects they might have, e.g., both division and modulo are
  undefined if the right hand side is zero. This is a problem because we
  potentially extended the domain under which we evaluate parameters,
  thus we might have introduced such undefined behaviour. To prevent
  that from happening we will now guard divisions and modulo operations
  in the parameters with a compare and select.

llvm-svn: 268023
This commit is contained in:
Johannes Doerfert
2016-04-29 10:36:58 +00:00
parent 4f3c985edd
commit bfaa63a82e
1 changed files with 20 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
polly/lib/Support/ScopHelper.cpp
View File

@@ -246,6 +246,15 @@ private:
const Region &R;
ValueMapT *VMap;
/// @brief Return the Value for @p E if it is not zero or else the value 1.
Value *selectOneIfZero(const SCEV *E, Instruction *IP) {
auto *Ty = E->getType();
auto *RHS = Expander.expandCodeFor(E, Ty, IP);
auto *Zero = ConstantInt::get(Ty, 0);
auto *Cond = new ICmpInst(IP, ICmpInst::ICMP_NE, RHS, Zero);
return SelectInst::Create(Cond, RHS, ConstantInt::get(Ty, 1), "", IP);
}
const SCEV *visitUnknown(const SCEVUnknown *E) {
// If a value mapping was given try if the underlying value is remapped.
@@ -273,7 +282,11 @@ private:
const SCEV *RHSScev = visit(SE.getSCEV(Inst->getOperand(1)));
Value *LHS = Expander.expandCodeFor(LHSScev, E->getType(), StartIP);
Value *RHS = Expander.expandCodeFor(RHSScev, E->getType(), StartIP);
Value *RHS = nullptr;
if (SE.isKnownNonZero(RHSScev))
RHS = Expander.expandCodeFor(RHSScev, E->getType(), StartIP);
else
RHS = selectOneIfZero(RHSScev, StartIP);
Inst = BinaryOperator::Create((Instruction::BinaryOps)Inst->getOpcode(),
LHS, RHS, Inst->getName() + Name, StartIP);
@@ -295,7 +308,12 @@ private:
return SE.getSignExtendExpr(visit(E->getOperand()), E->getType());
}
const SCEV *visitUDivExpr(const SCEVUDivExpr *E) {
return SE.getUDivExpr(visit(E->getLHS()), visit(E->getRHS()));
if (SE.isKnownNonZero(E->getRHS()))
return SE.getUDivExpr(visit(E->getLHS()), visit(E->getRHS()));
auto *RHSScev = visit(E->getRHS());
auto *IP = R.getEnteringBlock()->getTerminator();
auto *RHS = selectOneIfZero(RHSScev, IP);
return SE.getUDivExpr(visit(E->getLHS()), SE.getSCEV(RHS));
}
const SCEV *visitAddExpr(const SCEVAddExpr *E) {
SmallVector<const SCEV *, 4> NewOps;