intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-24 08:30:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

[clang-tidy] Address a few late comments.

Browse Source 
llvm-svn: 300588
This commit is contained in:
Haojian Wu
2017-04-18 20:47:34 +00:00
parent 2515410cb4
commit c2c2283223
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
clang-tools-extra/clang-tidy/performance/InefficientVectorOperationCheck.cpp
View File

@@ -99,7 +99,8 @@ void InefficientVectorOperationCheck::registerMatchers(MatchFinder *Finder) {
void InefficientVectorOperationCheck::check(
const MatchFinder::MatchResult &Result) {
if (Result.Context->getDiagnostics().hasUncompilableErrorOccurred())
auto* Context = Result.Context;
if (Context->getDiagnostics().hasUncompilableErrorOccurred())
return;
const SourceManager &SM = *Result.SourceManager;
@@ -113,7 +114,7 @@ void InefficientVectorOperationCheck::check(
llvm::SmallPtrSet<const DeclRefExpr *, 16> AllVectorVarRefs =
utils::decl_ref_expr::allDeclRefExprs(*VectorVarDecl, *LoopParent,
*Result.Context);
*Context);
for (const auto *Ref : AllVectorVarRefs) {
// Skip cases where there are usages (defined as DeclRefExpr that refers to
// "v") of vector variable `v` before the for loop. We consider these usages
@@ -128,19 +129,19 @@ void InefficientVectorOperationCheck::check(
}
}
llvm::StringRef LoopEndSource = clang::Lexer::getSourceText(
llvm::StringRef LoopEndSource = Lexer::getSourceText(
CharSourceRange::getTokenRange(LoopEndExpr->getSourceRange()), SM,
clang::LangOptions());
llvm::StringRef VectorVarName = clang::Lexer::getSourceText(
Context->getLangOpts());
llvm::StringRef VectorVarName = Lexer::getSourceText(
CharSourceRange::getTokenRange(
PushBackCall->getImplicitObjectArgument()->getSourceRange()),
SM, clang::LangOptions());
SM, Context->getLangOpts());
std::string ReserveStmt =
(VectorVarName + ".reserve(" + LoopEndSource + ");\n").str();
diag(PushBackCall->getLocStart(),
"'push_back' is called inside a loop; "
"consider pre-allocating the vector capacity before the loop.")
"consider pre-allocating the vector capacity before the loop")
<< FixItHint::CreateInsertion(ForLoop->getLocStart(), ReserveStmt);
}